Skip to content

Improve error handling in sdm.fit_ and sde.fit_ functions #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cwhanse opened this issue May 17, 2021 · 0 comments
Open

Improve error handling in sdm.fit_ and sde.fit_ functions #1235

cwhanse opened this issue May 17, 2021 · 0 comments

Comments

@cwhanse
Copy link
Member

cwhanse commented May 17, 2021

Diode model and diode equation fitting can fail for a variety of reasons: bad input IV curve data, lack of a well-defined minimum in the objective function, poor initial guess.

Current behavior is to let the supporting package (scipy, pysam) raise and handle errors. This behavior gives the user little information about the failure, and causes pvlib execution to stop rather than move on to the next IV curve.

pvlib could

  • provide information about the failure from the supporting package
  • use try/except conditions to avoid stopping execution at the first problem IV curve

See discussion at #1226 #1228 #1014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant