Skip to content

update benchmarks/tracking.py for SingleAxisTracker deprecation #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wholmgren opened this issue Jul 29, 2022 · 2 comments · Fixed by #1535
Closed

update benchmarks/tracking.py for SingleAxisTracker deprecation #1508

wholmgren opened this issue Jul 29, 2022 · 2 comments · Fixed by #1535

Comments

@wholmgren
Copy link
Member

Describe the bug
SingleAxisTracker is deprecated, but the tracking.py benchmark still uses it:

self.tracker = tracking.SingleAxisTracker()

To Reproduce
run asv tests. or look at the asv quick CI output

Expected behavior
no deprecation warnings in the benchmark test suite

Screenshots
If applicable, add screenshots to help explain your problem.

Versions:

@Naman-Priyadarshi
Copy link
Contributor

I wanted to work on the issue! Should i just remove the time_tracker_singleaxis function from the benchmark file?

Also when running asv dev I noticed that some of the benchmarking functions were failing, should i open a new issue regarding the same?

@wholmgren
Copy link
Member Author

Thanks @Naman-Priyadarshi, that would be great. Yes to both of your questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants