Update benchmark for tracking.py #1525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `time_tracker_singleaxis` function from the benchmark file
Updated whatsnew as per community guidelines
Naman-Priyadarshi
changed the title
kandersolar
reviewed
Aug 17, 2022
| def time_tracker_singleaxis(self): | ||
| with np.errstate(invalid='ignore'): | ||
| self.tracker.singleaxis(self.solar_position.apparent_zenith, | ||
| self.solar_position.azimuth) |
There was a problem hiding this comment.
In addition to this benchmark function, the definition of self.tracker on line 20 should also be removed as that's what is actually emitting the deprecation warning, see https://github.com/pvlib/pvlib-python/runs/7828546496?check_suite_focus=true#step:5:189
There was a problem hiding this comment.
thank you for clarifying, i'll make the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
benchmarks/tracking.pyforSingleAxisTrackerdeprecation #1508- [ ] Tests added- [ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).- [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.Removed
time_tracker_singleaxisfunction from the benchmark file asSingleAxisTrackerhas been deprecated.