Skip to content

Update reference in pvlib.iotools.read_cams #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kaesekopf opened this issue Aug 3, 2022 · 8 comments · Fixed by #1529
Closed

Update reference in pvlib.iotools.read_cams #1515

Kaesekopf opened this issue Aug 3, 2022 · 8 comments · Fixed by #1529

Comments

@Kaesekopf
Copy link

**Problem:

In the near future the documentation of the CAMS radiation service will be centralised under https://atmosphere.copernicus.eu/solar-radiation, and replace the two references that are mentioned in the function read_cams.

**Proposed solution:

Short term:
Set "https://atmosphere.copernicus.eu/solar-radiation" as first reference in the reference list.

Long term:
Once all documentation is moved to the new web page remove the two existing references.

@AdamRJensen
Copy link
Member

@Kaesekopf Thank you very much for this feedback!

Do you know if the link used in the documentation of the get_cams function will also be removed? https://www.soda-pro.com/help/cams-services/cams-mcclear-service/automatic-access

Will additional documentation that is more relevant than (https://atmosphere.copernicus.eu/solar-radiation) be added? Otherwise, we can just go ahead now and remove the two existing references and replace them with the single reference you mentioned.

Also, can you confirm that the link covers both CAMS Radiation and CAMS McClear?

@Kaesekopf
Copy link
Author

Kaesekopf commented Aug 3, 2022 via email

@Kaesekopf
Copy link
Author

Kaesekopf commented Aug 3, 2022 via email

@AdamRJensen
Copy link
Member

I'm inclined to wait with changing the references until the new documentation becomes available since the old links still work. This avoids making two pull requests and saves a bit of work. However, if you think it's important and useful to add the other link now, I'd also be happy to do that.

@Kaesekopf
Copy link
Author

OK, that sounds reasonable. I propose that I will reply to this thread again when the transfer is complete.

@Kaesekopf
Copy link
Author

Hallo Adam,

We had a slight internal misunderstanding within our project. The new CAMS Radiation Service documentation is to be found at:

https://confluence.ecmwf.int/display/CKB/CAMS+solar+radiation+time-series%3A+data+documentation

All the documentation for CAMS Radiation and CAMS McClear is already at this new website. So both the old sodapro references should be replaced by this single new one.

Thanks,

Jethro

@AdamRJensen
Copy link
Member

AdamRJensen commented Aug 4, 2022

This is fine with me. However, I think we need to keep this link in the documentation of the get_cams function as it describes the SodaPro API being used.

I assume that SodaPro will continue to serve data and that CAMS Radiation will not only be available from the Atmosphere Data Store?

@AdamRJensen
Copy link
Member

@Kaesekopf I didn't tag you in my response so perhaps you didn't get notified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants