pvlib.soiling.hsu
takes tilt
instead of surface_tilt
#1717
Labels
Milestone
pvlib.soiling.hsu
takes tilt
instead of surface_tilt
#1717
pvlib.soiling.hsu
takes atilt
parameter representing the same thing we normally callsurface_tilt
:pvlib-python/pvlib/soiling.py
Lines 13 to 14 in 7a2ec9b
pvlib-python/pvlib/soiling.py
Lines 33 to 34 in 7a2ec9b
I don't see any good reason for this naming inconsistency (I suspect
tilt
just got copied from the matlab implementation) and suggest we rename the parameter tosurface_tilt
with a deprecation.Also, the docstring parameter type description says it must be
float
, but the model's reference explicitly says time series tilt is allowed:The text was updated successfully, but these errors were encountered: