Skip to content

pvlib.soiling.hsu takes tilt instead of surface_tilt #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kandersolar opened this issue Apr 26, 2023 · 1 comment · Fixed by #1738
Closed

pvlib.soiling.hsu takes tilt instead of surface_tilt #1717

kandersolar opened this issue Apr 26, 2023 · 1 comment · Fixed by #1738

Comments

@kandersolar
Copy link
Member

pvlib.soiling.hsu takes a tilt parameter representing the same thing we normally call surface_tilt:

def hsu(rainfall, cleaning_threshold, tilt, pm2_5, pm10,
depo_veloc=None, rain_accum_period=pd.Timedelta('1h')):

tilt : float
Tilt of the PV panels from horizontal. [degree]

I don't see any good reason for this naming inconsistency (I suspect tilt just got copied from the matlab implementation) and suggest we rename the parameter to surface_tilt with a deprecation.

Also, the docstring parameter type description says it must be float, but the model's reference explicitly says time series tilt is allowed:

The angle is variable for tracking systems and is taken as the average angle over the time step.

@kandersolar
Copy link
Member Author

On second thought, I'm not seeing how this can be deprecated without reordering the parameters, which doesn't seem worth it to me. I'm inclined to rename it without deprecation in 0.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant