Skip to content

Broken GH links from gallery examples #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IoannisSifnaios opened this issue Jun 27, 2024 · 1 comment · Fixed by #2111
Closed

Broken GH links from gallery examples #2108

IoannisSifnaios opened this issue Jun 27, 2024 · 1 comment · Fixed by #2111
Milestone

Comments

@IoannisSifnaios
Copy link
Contributor

When clicking on the GitHub link in the gallery examples, the link to the source code is incorrect. It seems that the GH link is missing the subfolder where the gallery example is placed. See the below example:

Documentation link: https://pvlib-python.readthedocs.io/en/stable/gallery/bifacial/plot_pvfactors_fixed_tilt.html#sphx-glr-gallery-bifacial-plot-pvfactors-fixed-tilt-py
Link to source code: https://github.com/pvlib/pvlib-python/blob/main/docs/examples/plot_pvfactors_fixed_tilt.py

image

@kandersolar
Copy link
Member

Here is where that URL is determined: https://github.com/pvlib/pvlib-python/blob/main/docs/sphinx/source/conf.py#L443-L449

Looks like an oversight from when we moved the gallery pages into subdirectories! If so, that means those links have been broken for a few years, whoops...

I think it would be pretty straightforward to fix that code linked above to correctly account for the directory. A PR would be welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants