Skip to content

Broken GitHub links from gallery examples #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IoannisSifnaios
Copy link
Contributor

@IoannisSifnaios IoannisSifnaios commented Jun 28, 2024

@IoannisSifnaios IoannisSifnaios changed the title Broken GH links from gallery examples Broken GitHub links from gallery examples Jun 28, 2024
@IoannisSifnaios IoannisSifnaios marked this pull request as ready for review June 28, 2024 09:44
@kandersolar kandersolar added this to the v0.11.1 milestone Jun 28, 2024
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IoannisSifnaios IoannisSifnaios marked this pull request as draft July 1, 2024 15:24
@IoannisSifnaios IoannisSifnaios marked this pull request as ready for review July 1, 2024 16:02
@IoannisSifnaios
Copy link
Contributor Author

IoannisSifnaios commented Jul 1, 2024

Thanks @kandersolar! I think it is fixed now.

Is this something that needs to be added to the whatsnew file?

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No need for a whatsnew entry IMHO. Thanks @IoannisSifnaios!

@kandersolar kandersolar merged commit c7b8b00 into pvlib:main Jul 1, 2024
30 checks passed
@IoannisSifnaios IoannisSifnaios deleted the fix_GH_links_for_gallery_examples branch July 1, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken GH links from gallery examples
2 participants