-
Notifications
You must be signed in to change notification settings - Fork 1.1k
bifacial PV system modeling #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is this your practice problem, Cliff?!? |
uh no this will be a big lift :) #423 is a good practice problem. |
Mapping out how a fixed tilt bifacial PV system would be represented, here's a summary of my approach:
Interested in your thoughts. |
Getting the irradiance on different surfaces right seems to be the biggest challenge here. With the expectation of having different levels of irradiance on different cells (or rows of cells) some kind of mismatch model might be helpful too. |
Regarding each numbered item:
I do think a new subclass of
|
Thanks everyone - are you planning to work off the existing Python code in the github.com/NREL/bifacialvf repository? |
Yes, but substantially refactored to integrate with the rest of pvlib, for transparency and hopefully less maintenance risk. |
@cdeline thanks for sharing -- I didn't realize it was on github. Dare I ask what the license is? I am not a lawyer, but if the license is not BSD 3 compatible then I think we need to stick to working off of papers or similar instead of from code. |
Cool, I wasn't aware of it either. I suspect the pvlib version will look different enough that copyright will not be a problem. |
I should have asked first, thanks @wholmgren for bringing this up. @cdeline good to here. We'll keep prominent comments maintaining attribution and the supporting reference papers. |
@cdeline thanks for clarifying! |
@cwhanse is right. Updating bifacial PV system modeling to PVlib will be a great job. I have been working on this topic recently, I can contribute and there is a lot to learn about bifacial systems and how it differs from standard PV. The issue of bifacial energy yield prediction is of interest nowadays. |
@cwhanse @wholmgren I'm also interested in contributing on this if you guys need help, but is there any open PR? |
@anomam There isn't an open PR. I have a conversion of NREL's bifacialvf.py package to pvlib about 50% done. There's still substantial work left on that project. I glanced through the pvfactors package. Two concerns we should discuss as we consider a merge into pvlib, or another path to more closely linking pvfactors with pvlib:
If we decide to go forward with an import (e.g., make |
Curious, why convert NREL bifacialvf to pvlib? IMHO it would be better to leave it as an external dependence if possible. Ditto for other packages. |
In my opinion (but I've heard agreement from others) pvlib would benefit from an integral bifacial component (I could use it for our work at the lab). The NREL code will be difficult to maintain in its current state, and isn't really interfaced well with pvlib. So we thought it worth the effort to migrate. |
Ok |
@cwhanse thanks a lot for the replies. To answer your questions:
Speed is a top priority for me as well. And maintainability and simplicity are big ones too . |
@anomam we can add models to pvlib that depend on external packages. For pvfactors, I'd recommend making it an optional dependency, but I'll have to look at your package more carefully if we want to pursue this. No reason we can't implement/wrap several bifacial algorithms in pvlib if there is community interest. We have multiple clear sky algorithms, transposition models, solar position models, pv models, etc. |
@anomam 2 minutes for an 8760 is OK for me, for a bifacial simulation. If we can not have the geopandas dependency I think in the long run we'll be happier, since that package is low versioned and brings a chain of dependencies, I worry about maintaining the connection. I'd say go ahead with preparing a pull request. I really like the use of I will learn how to create a repository and get my partial translation of |
@cwhanse @wholmgren Thanks a lot for the feedback! |
Hi @cwhanse @wholmgren , I removed the |
@anomam happy to. |
implement NREL's rear-surface irradiance model for regular, fixed tilt arrays of bifacial PV models.
The text was updated successfully, but these errors were encountered: