-
Notifications
You must be signed in to change notification settings - Fork 1.1k
update sam library files #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Good point. I have not looked at the new files. I hope the format is the same. |
Oh, and were you planning to submit a pull request for this? I don't currently need anything from the new files, so I'm not likely to do it myself anytime soon. |
Yes I'll do it. |
Should we take the time to talk about pvfree for this? It might be easier to update the SAM database there, and have the option in pvlib to get the latest SAM databases from there, rather wait for a new release just to get the latest.
I'm sorry, I know I'm always promising to get this done, and it always seems to come up just short. |
I think we should update pvlib's files and cut a new release. In parallel, you can push pvfree forward with CEC modules and perhaps add some examples to the pvlib documentation. Later, we can have a discussion about whether or not it makes sense to continue bundling the files. |
Ok, ok :) I'll get on the update this afternoon. |
We've fallen a few years behind the SAM releases, so I think it's time to update the module and inverter CEC files.
The text was updated successfully, but these errors were encountered: