Skip to content

python 2.7 numpy 1.16 errors #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wholmgren opened this issue Jan 17, 2019 · 1 comment
Closed

python 2.7 numpy 1.16 errors #642

wholmgren opened this issue Jan 17, 2019 · 1 comment
Labels
Milestone

Comments

@wholmgren
Copy link
Member

https://travis-ci.org/pvlib/pvlib-python/jobs/480589919

Could be that we're using numpy functions in an unsupported way and they only work on some platforms/versions. Could also be related to the conda-forge builds.

@wholmgren wholmgren added this to the 0.6.1 milestone Jan 17, 2019
@wholmgren
Copy link
Member Author

A few things going on here:

  1. On python 2.7 numpy 1.16, for scalar input, np.digitize now returns a python int instead of an array with ndim == 0. This breaks the perez function with scalar input.
  2. A test (numba + calc delta t) that was expected to fail due to a ValueError now fails for a different reason. We never promised any specific failure here and I don't think anyone relies on the behavior. So, I suggest relaxing the xfail condition to any error.
  3. numpy 1.16 deprecates np.asscalar, so the logs are littered with deprecationwarnings.

PR incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant