Skip to content

numpy 1.16 compatibility #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2019
Merged

numpy 1.16 compatibility #644

merged 2 commits into from
Jan 21, 2019

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Jan 18, 2019 •
edited
Loading

  • Closes python 2.7 numpy 1.16 errors #642
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

@wholmgren wholmgren added this to the 0.6.1 milestone Jan 18, 2019
@wholmgren wholmgren added the bug label Jan 18, 2019
@wholmgren wholmgren requested a review from cwhanse January 18, 2019 19:53
cwhanse
cwhanse approved these changes Jan 18, 2019
View reviewed changes
pvlib/test/test_irradiance.py
@@ -273,6 +273,8 @@ def test_perez_scalar():
out = irradiance.perez(40, 180, 118.45831879, 939.95469881,
1321.1655834833093, 10.56413562, 144.76567754,
1.01688136)
# this will fail. out is ndarry with ndim == 0. fix in future version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to open an issue to track this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added #646

@wholmgren wholmgren merged commit d6d1492 into pvlib:master Jan 21, 2019
@wholmgren wholmgren deleted the npscalar branch January 21, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhanse cwhanse cwhanse approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@wholmgren @cwhanse