You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
pvlib has a policy that the output type should be as similar as possible to the input type. So, for all scalar input, most functions should return a scalar output. However, some functions return ndim=0 array outputs instead of true scalars. I know this happens with irradiance.perez, but I think it happens with a handful of functions.
@mikofski Thanks for pushing on that vectorized newton in scipy, it has been quite useful. I am a bit concerned about the different output formats in the scalar vs. vectorized cases, however. Seems like that leads to the same issue we are discussing here.
Thanks @markcampanelli for raising the issue with numpy and bringing it to my attention here. I'm less convinced that we should put much effort into it within pvlib.
Describe the bug
pvlib has a policy that the output type should be as similar as possible to the input type. So, for all scalar input, most functions should return a scalar output. However, some functions return ndim=0 array outputs instead of true scalars. I know this happens with
irradiance.perez
, but I think it happens with a handful of functions.To Reproduce
Expected behavior
The function should return a scalar, not an ndim=0 array.
Versions:
pvlib.__version__
: 0.6.0pandas.__version__
: manynumpy.__version__
: manyAdditional context
We've previously discussed creating utility functions and decorators to handle type issues like this one. See #635 for example.
The first thing we need to do is catalog which functions exhibit this behavior.
The text was updated successfully, but these errors were encountered: