You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ModelChain.prepare_inputs and ModelChain.run_model currently default to running a model using clear sky data if none of ghi, dni, and dhi are in the input weather.
My original motivation for including this feature was that it would make it easier to get started with ModelChain. But it's not practically useful and arguably makes the documentation of an already confusing class even worse.
It also violates the "explicit is better than implicit" guidance -- better to require that users provide their own data. Their own data is only a method call away with location.get_clearsky.
The text was updated successfully, but these errors were encountered:
ModelChain.prepare_inputs
andModelChain.run_model
currently default to running a model using clear sky data if none ofghi
,dni
, anddhi
are in the inputweather
.My original motivation for including this feature was that it would make it easier to get started with ModelChain. But it's not practically useful and arguably makes the documentation of an already confusing class even worse.
It also violates the "explicit is better than implicit" guidance -- better to require that users provide their own data. Their own data is only a method call away with
location.get_clearsky
.The text was updated successfully, but these errors were encountered: