Skip to content

Remove clear sky fallback option from ModelChain.prepare_inputs and run_model #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wholmgren opened this issue May 3, 2019 · 3 comments
Labels
Milestone

Comments

@wholmgren
Copy link
Member

ModelChain.prepare_inputs and ModelChain.run_model currently default to running a model using clear sky data if none of ghi, dni, and dhi are in the input weather.

My original motivation for including this feature was that it would make it easier to get started with ModelChain. But it's not practically useful and arguably makes the documentation of an already confusing class even worse.

It also violates the "explicit is better than implicit" guidance -- better to require that users provide their own data. Their own data is only a method call away with location.get_clearsky.

@wholmgren wholmgren added the api label May 3, 2019
@cwhanse
Copy link
Member

cwhanse commented May 3, 2019

I agree with removing the implicit clearsky weather.

@wholmgren
Copy link
Member Author

Ok, I'm going to put a deprecation warning into 0.6.2.

@wholmgren
Copy link
Member Author

closed by #773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants