Skip to content

Fix and document clearsky_model for ModelChain #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 14, 2023

Conversation

cwhanse
Copy link
Member

@cwhanse cwhanse commented Dec 1, 2023

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Clarifying why ModelChain has attribute clearsky_model. See discussion.

@kandersolar kandersolar added this to the v0.10.3 milestone Dec 4, 2023
@kandersolar
Copy link
Member

Can someone point me to a line of code where clearsky_model actually has an effect? From what I can tell, it is not used anywhere. The clear-sky fallback was removed in v0.7.0; maybe this parameter should have been removed as well but was overlooked? See:

@cwhanse
Copy link
Member Author

cwhanse commented Dec 4, 2023

Can someone point me to a line of code where clearsky_model actually has an effect?

Now that I look carefully, I can't. I saw the line in modelchain._complete_irradiance where a clear-sky model is run and thought "Aha" and didn't look further.

Rather than drop clearsky_model (I'm OK with that), we could instead pass model=clearsky_model.

@cwhanse cwhanse mentioned this pull request Dec 8, 2023
15 tasks
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kandersolar kandersolar changed the title Add note clarifying clearsky_model for ModelChain Fix and document clearsky_model for ModelChain Dec 14, 2023
@kandersolar kandersolar merged commit ae84817 into pvlib:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants