Skip to content

Increase minimum pandas/numpy versions in v0.8.0 #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CameronTStark opened this issue Feb 13, 2020 · 1 comment
Closed

Increase minimum pandas/numpy versions in v0.8.0 #887

CameronTStark opened this issue Feb 13, 2020 · 1 comment

Comments

@CameronTStark
Copy link
Contributor

A need to increase the pandas version has been identified via the work in #885 that sought to remove the needs_pandas_0_22 and needs_pandas_0_17 decorators. For example, the function pvlib.irradiance.perez() specifically outputs different components whether it uses pandas>=0.18 or before and the tests are required to deal with this difference. From this perspective the goal is to simplify tests and avoid different functionality within supported versions of pandas.

A good guideline for the process of increasing versions is proposed by @wholmgren in #828 where he outlines the criteria as:

I suggest that we instead aggressively drop numpy/python versions when 1. there is a reason to do so and 2. the versions are outside the NEP-29 windows

The simplification of the testing suite and standardizing outputs certainly fall into 1. above as a criteria for deciding on the minimum pandas versions.

@wholmgren
Copy link
Member

done in some recent PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants