-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add sphinx-toggleprompt #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sphinx-toggleprompt #1096
Conversation
It's not formatting the "Out[19]:" correctly. Will fix |
This is good for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @jurasofish. @pvlib/pvlib-maintainer feel free to merge if you're happy with this approach
Thanks again @jurasofish |
Looking at the |
It doesn't hide comments generally, for example see https://docs.python.org/3/tutorial/controlflow.html#for-statements That modelchain example is a tricky case because the IPython formatting has placed the comment outside an input prompt and formatted it the same as an output, so it's indistinguishable from an output. The way to tackle it would be to get the upstream IPython formatter to give it a unique style which could then be hidden. Might need changes in pygments, not sure. Or, the IPython formatter could put comments next to "In [xx]:" cells like any normal input. |
docs/sphinx/source/api.rst
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).