-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Restructure documentation, port tutorials #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* What it is not | ||
* Comparison with PVLIB_MATLAB | ||
* Installation | ||
* Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the top level "Examples".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I don't have a strong preference here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to keep the top level.
This helps to reduce maxdepth
to 1 once there are many sub-pages.
So it seems that we are set with the ToC for now? |
Yes, with the understanding that we'll probably want to change some of it once we start to see the content. |
Sure. Seems stepwise is a better approach.... |
@wholmgren I am likly to pick this one up step by step because I wanna see the system tut in. |
The documentation has grown since this conversation started. I would like to see more documentation pages similar to our Time and time zones, Clearsky, and Forecasting pages. Transposition and solar position pages would be relatively straightforward to write. I think a good ModelChain page is very important, but more work. I recommend closing this PR and doing these (or something like them that you care more about) one PR at a time. |
Thanks for responding. Currently, my preference is with the pvsystem tutorial initiated by @jforbess
This is what I was planning to convert the existing notebook into. May question now: This shall be there to ensure that we do not damage the docs when refractoring the api of the core lib. e.g. there are soem error in http://pvlib-python.readthedocs.io/en/latest/forecasts.html Some guidance would be appreciated before writing new pages. Regarding ToC & structure, I see that in future there may be the followings technical pages:
|
I've never written any doctests but I think you can do them in ipython directive. It will be a lot of work, so good luck. As I said before, go ahead and write up one new page in a new pr. I've explained the error on the forecasting page multiple times. |
As alternative, we could use a separate code file being test & then use it as listing in the Spinx docs. |
http://matplotlib.org/sampledoc/ipython_directive.html
|
There are some useful ideas in the discussion above, but the way to make progress at this point is starting and finishing one small PR before moving on to the next. |
This is the code for #120. Based on the pvsystem branch by @wholmgren
The last commit now has a potential ToC as a list.
I think discussing using the list is easier and less effort.
Let's agree ToC level by ToC level.
To revewi, please also look at the RTD version:
Contents (potential new ToC)