Skip to content

Restructure documentation, port tutorials #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

dacoex
Copy link
Contributor

@dacoex dacoex commented Feb 10, 2016

This is the code for #120. Based on the pvsystem branch by @wholmgren

The last commit now has a potential ToC as a list.

I think discussing using the list is easier and less effort.
Let's agree ToC level by ToC level.

To revewi, please also look at the RTD version:
Contents (potential new ToC)

@wholmgren wholmgren changed the title Pvsystem tutport Restructure documentation, port tutorials Feb 10, 2016
* What it is not
* Comparison with PVLIB_MATLAB
* Installation
* Examples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the top level "Examples".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I don't have a strong preference here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to keep the top level.
This helps to reduce maxdepth to 1 once there are many sub-pages.

@dacoex
Copy link
Contributor Author

dacoex commented Feb 10, 2016

So it seems that we are set with the ToC for now?

@wholmgren
Copy link
Member

Yes, with the understanding that we'll probably want to change some of it once we start to see the content.

@dacoex
Copy link
Contributor Author

dacoex commented Feb 10, 2016

Sure. Seems stepwise is a better approach....

@dacoex
Copy link
Contributor Author

dacoex commented Aug 17, 2016

@wholmgren I am likly to pick this one up step by step because I wanna see the system tut in.
Would you still agree to port the essential notebook based tutorials to python code / doctest so that they can be tested through an api restructuring as it happened with v3.0?

@wholmgren
Copy link
Member

The documentation has grown since this conversation started. I would like to see more documentation pages similar to our Time and time zones, Clearsky, and Forecasting pages. Transposition and solar position pages would be relatively straightforward to write. I think a good ModelChain page is very important, but more work. I recommend closing this PR and doing these (or something like them that you care more about) one PR at a time.

@dacoex
Copy link
Contributor Author

dacoex commented Aug 18, 2016

Thanks for responding.

Currently, my preference is with the pvsystem tutorial initiated by @jforbess

I would like to see more documentation pages similar to our Time and time zones, Clearsky, and >Forecasting pages.

This is what I was planning to convert the existing notebook into.

May question now:
How do we ensure that the code in the documentation always up-to date?
Is it included in the tests?

This shall be there to ensure that we do not damage the docs when refractoring the api of the core lib.

e.g. there are soem error in http://pvlib-python.readthedocs.io/en/latest/forecasts.html

Some guidance would be appreciated before writing new pages.

Regarding ToC & structure, I see that in future there may be the followings technical pages:

- Fundamentals & Basics
   |---- Time and time zones
   |---- Clearsky
   |---- solar position
   |---- Transposition 
   |---- Input data
           |---- US TMY
           |---- Forecast & weather model (the whole section of Accessing Forecast Data to Weather Models deal with getting data)
           |---- other providers
           |---- local measurement & SCADA data (link to https://github.com/sandialabs/pecos )
- Modelling & Simulations
   |---- Trackers
   |---- Complete PV system
   |---- Sensitivity studies
   |---- Forecasting 
   |---- Cross-comparison & validation with other tools
   |---- etc.
- Analysis & Presentation
   |---- Statistisc ( ... should create a feature request issue because nothing there yet)
   |---- Plotting 
   |---- Reporting ( ... pvlib could be used to create a report like: 
                                http://solargis.com/assets/sample/SolarGIS-pvPlanner-sampleReport.xls
                                http://solargis.com/assets/sample/SolarGIS-pvPlanner-sampleReport.pdf) 

@wholmgren
Copy link
Member

I've never written any doctests but I think you can do them in ipython directive. It will be a lot of work, so good luck. As I said before, go ahead and write up one new page in a new pr.

I've explained the error on the forecasting page multiple times.

@dacoex
Copy link
Contributor Author

dacoex commented Aug 18, 2016

I've never written any doctests but I think you can do them in ipython directive. It will be a lot of >work, >so good luck.

As alternative, we could use a separate code file being test & then use it as listing in the Spinx docs.

@wholmgren
Copy link
Member

http://matplotlib.org/sampledoc/ipython_directive.html

.. ipython::

   In [1]: x = 'hello world'

   # this will raise an error if the ipython output is different
   @doctest
   In [2]: x.upper()
   Out[2]: 'HELLO WORLD'

@wholmgren
Copy link
Member

There are some useful ideas in the discussion above, but the way to make progress at this point is starting and finishing one small PR before moving on to the next.

@wholmgren wholmgren closed this Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants