De-noise CI output #1294
Merged
De-noise CI output #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhanse
reviewed
Sep 8, 2021
pvlib/tests/test_tracking.py
Outdated
| ('2019-01-01T15:00-0500', 17.296785, 217.446538, 39.562, 39.562), | ||
| ('2019-01-01T16:00-0500', 9.461862, 229.102218, 61.587, 32.339), | ||
| ('2019-01-01T17:00-0500', 0.524817, 239.330401, 79.530, 5.490)], | ||
| [('2019-01-01T13:00', 2.404287, 122.79177, -84.440, -10.899), |
There was a problem hiding this comment.
I'm a bit surprised by this change. I'm sure it works but for style and clarity I would think including the timezone is better.
There was a problem hiding this comment.
Can we use DataFrame, assert_series_equal, and assert_frame_equal instead of array and assert_allclose? I think that would be more aligned with typical use cases and would solve the timezone problem.
There was a problem hiding this comment.
Some context here regarding numpy datetimes and timezones: https://numpy.org/doc/stable/release/1.11.0-notes.html#datetime64-changes
wholmgren
reviewed
Sep 8, 2021
setup.cfg
Outdated
Comment on lines
36
to
37
| ignore:`np.typeDict` is a deprecated alias:DeprecationWarning:.*tables: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] Tests added[ ] Updates entries todocs/sphinx/source/api.rstfor API changes.[ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.It's annoying to scroll through what seems like
np.inflines of warnings in the CI output. Try finding anything in this mess: https://dev.azure.com/solararbiter/pvlib%20python/_build/results?buildId=5455&view=logs&j=fc432b8b-e2e3-594e-d8b1-15597b6c1d62&t=309866e1-2cf4-5f00-3d0a-999fc3a0f279Seems like I'm not the only one annoyed by it, see @wholmgren's #1287 (comment)
Probably a lot of it comes from our dependencies, but at least some of it can get fixed here. Might be worth suppressing some of the noisier warnings from our dependencies if we can't do anything about it.
I assume there's no need to get this into 0.9.0 so I'm not rushing to get this one done.