Allow scalar surface orientation inputs to pvlib.bifacial.pvfactors_timeseries #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhanse
approved these changes
Dec 29, 2021
cwhanse
reviewed
Dec 29, 2021
pvlib/bifacial.py
Outdated
| dni = np.array(dni) | ||
| dhi = np.array(dhi) | ||
| # GH 1127, GH 1332 | ||
| if np.isscalar(surface_tilt): |
There was a problem hiding this comment.
Use numpy.atleast_1d? It would avoid the if but otherwise I don't know if it's better.
There was a problem hiding this comment.
I think the requirement is that surface_tilt be an array of the same length as the meteo inputs, so np.atleast_1d would still need to be followed by a conditional np.repeat or something.
There was a problem hiding this comment.
full_like docs say it requires a scalar input, but this works:
a = np.array([1,2,3])
np.full_like(a, 7)
array([7, 7, 7])
np.full_like(a, np.array([7,8,9]))
array([7, 8, 9])
There was a problem hiding this comment.
Seems to work with lists and Series too. Always happy to learn a new numpy function :)
wholmgren
approved these changes
Jan 3, 2022
pvlib/bifacial.py
Outdated
| dni = np.array(dni) | ||
| dhi = np.array(dhi) | ||
| # GH 1127, GH 1332 | ||
| if np.isscalar(surface_tilt): |
There was a problem hiding this comment.
full_like docs say it requires a scalar input, but this works:
a = np.array([1,2,3])
np.full_like(a, 7)
array([7, 7, 7])
np.full_like(a, np.array([7,8,9]))
array([7, 8, 9])
|
New test failures are the same as #717 (comment), so ignoring here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates entries todocs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.As mentioned in #1332, I opted to rework the function to allow scalar orientation inputs instead of editing the docstring to prohibit them. I also did some cleanup in the tests to avoid code duplication.