Skip to content

Added Benchmarking functions for scaling.py module #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 13, 2022

Conversation

Naman-Priyadarshi
Copy link
Contributor

@Naman-Priyadarshi Naman-Priyadarshi commented Apr 18, 2022

Created and Added Benchmarking for pvlib.scaling.latlon_to_xy, pvlib.scaling._compute_wavelet, pvlib.scaling._compute_vr, and pvlib.scaling.wvm functions for the module scaling

  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here. The asv/quick job looks good so I'll go ahead and merge this. Thanks @Naman-Priyadarshi!

@kandersolar kandersolar merged commit f928d39 into pvlib:master Jun 13, 2022
kandersolar added a commit to roger-lcc/pvlib-python that referenced this pull request Jun 13, 2022
* Added Benchmarking functions for

* Solved more Stickler CI issues

* Updated v0.9.2.rst

* Made changes in code formatting

Co-authored-by: Kevin Anderson <[email protected]>
@Naman-Priyadarshi Naman-Priyadarshi deleted the scaling_benchmarking branch June 15, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants