Skip to content

Move surface orientation calculation from tracking.singleaxis to new function; switch to Marion & Dobos 2013 equations #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 5, 2022

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Jun 22, 2022

@kandersolar kandersolar added this to the 0.9.2 milestone Jun 22, 2022
@kandersolar kandersolar marked this pull request as ready for review June 22, 2022 02:22
@kandersolar kandersolar merged commit c0daa5d into pvlib:master Jul 5, 2022
@kandersolar kandersolar deleted the sat_split branch July 5, 2022 14:15
@wholmgren
Copy link
Member

As a follow up, should we remove https://github.com/pvlib/pvlib-python/blob/master/docs/tutorials/tracking.ipynb? Looks like a lot of work to bring that notebook up to date with the current implementation and the newer features.

I'd also recommend updating the PR title to reflect the use of new equations.

@kandersolar
Copy link
Member Author

should we remove https://github.com/pvlib/pvlib-python/blob/master/docs/tutorials/tracking.ipynb?

Ugh, maybe. I hate to delete useful info, even if the specific implementation doesn't match the current pvlib. If there is effort to spend, I think I'd rather put it into a new User Guide page to replace that notebook instead of updating the notebook itself. Or maybe improved gallery examples as suggested in #1077 (review).

I'd also recommend updating the PR title to reflect the use of new equations.

Good point. Wish I had done that before the title got used for the squashed commit message. Oh well!

@kandersolar kandersolar changed the title Move surface orientation calculation from tracking.singleaxis to new function Move surface orientation calculation from tracking.singleaxis to new function; switch to Marion & Dobos 2013 equations Jul 6, 2022
@wholmgren
Copy link
Member

I agree that a user guide page and/or gallery examples are better than updating the notebook.

I didn't pay much attention to this PR since the title suggested that it was just a matter of moving code from one function to another :)

@kandersolar
Copy link
Member Author

I didn't pay much attention to this PR since the title suggested that it was just a matter of moving code from one function to another :)

Yep, that's my bad. Please feel free to point out anything you wish had been done prior to merging and I will happily rectify it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider extracting the surface orientation calculation in pvlib.tracking.singleaxis() to its own function
3 participants