Skip to content

Update README badges #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Update README badges #1482

merged 3 commits into from
Jun 22, 2022

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Jun 22, 2022

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Forgot to switch the README badge from Azure to GH Actions in #1306.

Also, seems like we haven't pushed any results to coveralls since 2020: https://coveralls.io/github/pvlib/pvlib-python. Probably #1040 is relevant. Is there any value in using both coveralls and codecov? If not, probably it makes sense to get rid of the coveralls badge.

Also on the topic of CI cruft, can we remove .landscape.yml in the repo root? Seems like it has not been used for some years.

@kandersolar kandersolar added this to the 0.9.2 milestone Jun 22, 2022
@mikofski
Copy link
Member

what's .landscape.yml?

@kandersolar
Copy link
Member Author

what's .landscape.yml?

The config for landscape, which I guess is a linting service based on the title of #257. 608cc01 removed the badge but left the config file behind.

@wholmgren
Copy link
Member

landscape.io had a nice dashboard to measure code health, then it fell into disrepair. Fine to remove the file.

@wholmgren
Copy link
Member

Also, seems like we haven't pushed any results to coveralls since 2020: https://coveralls.io/github/pvlib/pvlib-python. Probably #1040 is relevant. Is there any value in using both coveralls and codecov? If not, probably it makes sense to get rid of the coveralls badge.

codecov also feels like it's falling into disrepair, but we certainly shouldn't link to a service that we're not actively using.

Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kanderso-nrel merge when ready!

@kandersolar kandersolar merged commit c8b04a5 into pvlib:master Jun 22, 2022
@kandersolar kandersolar deleted the ghactions_badge branch June 22, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants