Skip to content

Remove benchmarks for deprecated SingleAxisTracker #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 11, 2022
Merged

Remove benchmarks for deprecated SingleAxisTracker #1535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
64954aa
Update tracking.py
Naman-Priyadarshi Aug 25, 2022
81c3669
Update v0.9.3.rst
Naman-Priyadarshi Aug 25, 2022
fc45092
Merge branch 'master' into bench-track.py
Naman-Priyadarshi Aug 30, 2022
f7d8a31
Merge branch 'master' into bench-track.py
Naman-Priyadarshi Sep 1, 2022
ebbff0e
Merge branch 'master' into bench-track.py
Naman-Priyadarshi Sep 22, 2022
d586046
Merge remote-tracking branch 'upstream/main' into pr/1535
kandersolar Nov 11, 2022
12b6161
move whatsnew entry from 0.9.3 to 0.9.4
kandersolar Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions benchmarks/benchmarks/tracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ def setup(self):
self.solar_position = solarposition.get_solarposition(self.times,
self.lat,
self.lon)
self.tracker = tracking.SingleAxisTracker()

def time_singleaxis(self):
with np.errstate(invalid='ignore'):
Expand All @@ -28,8 +27,3 @@ def time_singleaxis(self):
max_angle=60,
backtrack=True,
gcr=0.45)

def time_tracker_singleaxis(self):
with np.errstate(invalid='ignore'):
self.tracker.singleaxis(self.solar_position.apparent_zenith,
self.solar_position.azimuth)
3 changes: 3 additions & 0 deletions docs/sphinx/source/whatsnew/v0.9.4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Documentation

Benchmarking
~~~~~~~~~~~~~
* Removed ``time_tracker_singleaxis`` function from tracking.py (:issue:`1508`, :pull:`1535`)


Requirements
Expand All @@ -43,3 +44,5 @@ Contributors
* Christian Orner (:ghuser:`chrisorner`)
* Saurabh Aneja (:ghuser:`spaneja`)
* Marcus Boumans (:ghuser:`bowie2211`)
* Naman Priyadarshi (:ghuser:`Naman-Priyadarshi`)