-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add ASTM E1036 parameter extraction #1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here is a start at adding ASTM E1036 IV curve parameter extraction. Open to any and all feedback including naming of function/module/parameters. The original code was object-oriented and included plotting functionality. I have simplified it to a stand alone function to avoid opening a whole can of worms about plotting and to align with the overall low-level functional building block approach of pvlib, but we can re-evaluate these choices if there is interest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree plotting should not be in pvlib itself, at least at this time. Could be a good fit for the example gallery. I'm neutral on the pvlib.ivtools.params
name, don't love it but can't think of anything better.
pvlib/ivtools/params.py
Outdated
All rights reserved. | ||
''' | ||
|
||
df = pd.DataFrame() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything could all be calculated with numpy only without many changes, if that is of interest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting suggestion. I don't think I will have time to tackle it, but if you feel it makes a sufficient improvement please go for it. Tests are in place now so it should be easy to verify that it has worked.
Co-authored-by: Kevin Anderson <[email protected]>
@mdeceglie fyi we are still working out language for the copyright renewal. Thanks for your patience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few sphinx nitpicks but otherwise LGTM pending the copyright question.
I'm okay with the new pvlib.ivtools.params
module name but I'm not really familiar with this area. Can we imagine any other related functionality we may want to add in the future that might make us wish we had chosen a different module name?
Co-authored-by: Kevin Anderson <[email protected]>
Co-authored-by: Kevin Anderson <[email protected]>
Co-authored-by: Kevin Anderson <[email protected]>
Co-authored-by: Kevin Anderson <[email protected]>
It might make sense to move this into the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, not a complete review.
@cwhanse OK to merge? |
Yes after the whatsnew conflict is resolved of course. |
docs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.This PR adds the ASTM E1036 methods for extracting performance parameters from IV curves. The code has been adapted from https://github.com/NREL/iv_params