Revise golden mean search convergence #1606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandersolar
reviewed
Dec 8, 2022
kandersolar
approved these changes
Dec 8, 2022
| (:issue:`1565`, :pull:`1567`) | ||
| * Add optional ``return_components`` parameter to :py:func:`pvlib.irradiance.haydavies` to return | ||
| individual diffuse irradiance components (:issue:`1553`, :pull:`1568`) | ||
| individual diffuse irradiance components. (:issue:`1553`, :pull:`1568`) |
There was a problem hiding this comment.
Thank you for cleaning up our negligence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Adjusts convergence criteria for
tools._golden_sect_DataFrameto handle edge case when upper and lower bounds are equal (which can occur when e.g. v_oc =0 is returned bypvsystem.singlediode.Ditched the limit on iterations as duplicative of testing the width of the test point interval. Moved the optimum from the left test point to the average of the two test points.