Skip to content

Correct singlediode.bishop88_mpp docs #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Conversation

cwhanse
Copy link
Member

@cwhanse cwhanse commented Dec 15, 2022

  • Closes singlediode.bishop88_mpp return is different from docstring #1613
  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

bishop88_mpp calls bishop88 in its return line, thus the returned type is a tuple.

@kandersolar kandersolar added this to the 0.9.4 milestone Dec 15, 2022
@kandersolar kandersolar mentioned this pull request Dec 15, 2022
9 tasks
@kandersolar kandersolar merged commit 771eb46 into pvlib:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

singlediode.bishop88_mpp return is different from docstring
2 participants