Skip to content

get_psm3: add optional url parameter and update default hourly url to new 3.2.2 endpoint #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 22, 2023
Merged

get_psm3: add optional url parameter and update default hourly url to new 3.2.2 endpoint #1736

merged 8 commits into from
May 22, 2023

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented May 16, 2023 •
edited
Loading

  • Closes iotools.get_psm3 may need some updates for the new 2021 data #1591
  • I am familiar with the contributing guidelines
  • Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@kandersolar kandersolar added enhancement io remote-data triggers --remote-data pytests labels May 16, 2023
@kandersolar kandersolar added this to the 0.10.0 milestone May 16, 2023
@kandersolar kandersolar added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels May 16, 2023
@kandersolar kandersolar added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels May 16, 2023
@kandersolar kandersolar requested a review from AdamRJensen May 16, 2023 17:56
AdamRJensen
AdamRJensen approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried all the various configurations that I could think of, and it all seems to check out.

Thanks @kandersolar!

@kandersolar kandersolar mentioned this pull request May 16, 2023
Closed
@kandersolar kandersolar merged commit 30c62e3 into pvlib:main May 22, 2023
@kandersolar kandersolar deleted the psm3 branch May 22, 2023 17:31
@kandersolar kandersolar mentioned this pull request Jun 30, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamRJensen AdamRJensen AdamRJensen approved these changes

Assignees
No one assigned
Labels
enhancement io remote-data triggers --remote-data pytests
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

iotools.get_psm3 may need some updates for the new 2021 data
2 participants
@kandersolar @AdamRJensen