-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add spectral factor gallery example #2114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix directory, add refs
That sounds reasonable to me!
If the default formatting is not sufficient, I suggest leaving the index of the data as-is and applying formatting to the plot rather than the data. But I'll say that I rarely find myself displeased with the default timestamp formatting, so I wonder if it's really needed in this case.
I would just subset the dataframe for the second plot. Something like
I suggest performing the simulation for the full time series (including the dawn/dusk hours and even nighttime), and just setting the y-axis limits to zoom into the region of interest. Something like |
Thank you for this feedback @kandersolar |
Co-authored-by: Kevin Anderson <[email protected]>
Co-authored-by: Kevin Anderson <[email protected]>
Co-authored-by: Kevin Anderson <[email protected]>
Co-authored-by: Kevin Anderson <[email protected]>
Co-authored-by: Kevin Anderson <[email protected]>
Co-authored-by: Kevin Anderson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @RDaxini! Some ideas from my side...
Co-authored-by: Ioannis Sifnaios <[email protected]>
Co-authored-by: Ioannis Sifnaios <[email protected]>
trying new plots (goal to increase size)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the differentiation between spectral factor and spectral mismatch is unclear, can this somehow be explained in the first paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments below; the example is easy to follow, I like it.
Co-authored-by: Echedey Luis <[email protected]> Co-authored-by: Adam R. Jensen <[email protected]>
Good to go now from my side. |
Thanks @RDaxini! |
docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.Context described in Issue #2107
Docs here
Outdated:
Current questions I'd still like to ask:
where I effectively reset and then reformat the index, and then replot a new graph seems inefficient. Is it possible to do this in a better way? Somehow duplicating and limiting the axis of the first graph perhaps?
M
generated by the First Solar Model when the other two modules yield0
, but this means the y-axis must start from zero, which cramps up the plots to the point where it is hard to visualise differences between the curves. Starting at 0700 resolves this but means that one non-zero value of M is omitted. PV output at these times is likely negligible but for the purpose of illustrating a calculation ofM
using different models I am still wondering what might be the best option here.