[MAINT]: Remove deprecated pvlib.atmosphere.first_solar_spectral_correction
#2131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echedey-ls
changed the title
pvlib.atmosphere.first_solar_spectral_correctionpvlib.atmosphere.first_solar_spectral_correction
|
@echedey-ls this looks good to me. Can you add a whatsnew entry (in the 0.11.3 file; I will rename it to 0.12.0 in the release finalization PR) and resolve the merge conflict? |
|
Done! 🚀 |
kandersolar
approved these changes
Mar 14, 2025
echedey-ls
deleted the
remove-deprecated-atmosphere-first-solar-spectral-factor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pvlib.atmosphere.first_solar_spectral_correctionnot scheduled for removal #2130[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.Pending whatsnew entry. I propose waiting for v0.12 since this is a breaking change, thou I doubt we need to be very careful with a function already deprecated for a whole minor version.