-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Muneer transposition model #2184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
02ae568
ea15728
feafcea
e4646d4
8066458
1798da8
4281d61
8b13595
6cd63a8
fa4d8e6
8318d5b
d5c8bc3
8cbee57
20c8fae
a326e94
e0d85c0
30fb33a
e1a7f74
618ca91
373d3e0
e517a84
9452248
b2d5239
36f633e
982d2f9
eecc05e
83b5036
6bd1d51
4fb4bae
4c69d6f
b93aa05
c2248f1
91fd117
b8910de
0591323
aed0e6d
2d4b10f
bec7412
a3e3e3c
927c8a8
7cfd605
5298cb2
ce6f5c0
ce42241
5632bda
b2128cf
f9fb65c
c0caf04
2142559
4e58192
bedd18b
b5e4aec
1bcf20d
c9b9214
519861e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -994,6 +994,56 @@ | |||||||||||||
return sky_diffuse | ||||||||||||||
|
||||||||||||||
|
||||||||||||||
def muneer(surface_tilt, dhi, b): | ||||||||||||||
''' | ||||||||||||||
Determine diffuse irradiance from the sky on a tilted surface using | ||||||||||||||
the Muneer [1]_ model. | ||||||||||||||
|
||||||||||||||
Parameters | ||||||||||||||
---------- | ||||||||||||||
surface_tilt : numeric | ||||||||||||||
Surface tilt angle in decimal degrees. Tilt must be >=0 and | ||||||||||||||
<=180. The tilt angle is defined as degrees from horizontal | ||||||||||||||
(e.g. surface facing up = 0, surface facing horizon = 90) | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Got the wording from perez. For consistency, should other functions also be updated or shall I keep the one that currently is (from perez)? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. echedey-ls edits are an improvement but I'm not in favor of changing documentation for other functions. You can change it here, but I think it's not a big deal if we use the old language. |
||||||||||||||
|
||||||||||||||
dhi : numeric | ||||||||||||||
Diffuse horizontal irradiance in W/m^2. DHI must be >=0. | ||||||||||||||
BernatNicolau marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||
|
||||||||||||||
b : numeric | ||||||||||||||
Radiance distribution index, introduced by Moon and Spencer [2]_ to model | ||||||||||||||
luminance distribution of overcast sky. | ||||||||||||||
BernatNicolau marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||
|
||||||||||||||
'best' values of b as found for Easthampstead data: | ||||||||||||||
isotropic: b = 0 | ||||||||||||||
shaded surface: b = 5.73 | ||||||||||||||
sunlit surface under overcast sky: b = 1.68 | ||||||||||||||
sunlit surface under non-overcast sky: b = -0.62 | ||||||||||||||
|
||||||||||||||
BernatNicolau marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||
|
||||||||||||||
Returns | ||||||||||||||
------- | ||||||||||||||
diffuse : numeric | ||||||||||||||
BernatNicolau marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||
The sky diffuse component of the solar radiation. | ||||||||||||||
BernatNicolau marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||
|
||||||||||||||
References | ||||||||||||||
---------- | ||||||||||||||
.. [1] Muneer, T., 1990, Solar radiation model for Europe. | ||||||||||||||
Building services engineering research and technology, 11: 153-163. | ||||||||||||||
|
||||||||||||||
.. [2] Moon P and Spencer D E Illumination from a non-uniform sky | ||||||||||||||
Trans. Illum. Eng. Soc. (London) 37 707-725 (1942) | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These two sources follow different citation convention. Also, could you add a DOI? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolved in 8b13595 . First time I do it, @AdamRJensen can you check if it is alright? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @BernatNicolau both look typed out correctly, but I don't think the second DOI value is correct (review comment) |
||||||||||||||
''' | ||||||||||||||
|
||||||||||||||
term1 = 2 * b / (np.pi * (3 + 2 * b)) | ||||||||||||||
term2 = (tools.sind(surface_tilt) | ||||||||||||||
- surface_tilt * tools.cosd(surface_tilt) | ||||||||||||||
- np.pi * (1 - tools.cosd(surface_tilt)) * 0.5 | ||||||||||||||
) | ||||||||||||||
sky_diffuse = dhi * ((1 + tools.cosd(surface_tilt)) * 0.5 + term1 * term2) | ||||||||||||||
|
||||||||||||||
return sky_diffuse | ||||||||||||||
|
||||||||||||||
|
||||||||||||||
def perez(surface_tilt, surface_azimuth, dhi, dni, dni_extra, | ||||||||||||||
solar_zenith, solar_azimuth, airmass, | ||||||||||||||
model='allsitescomposite1990', return_components=False): | ||||||||||||||
|
Uh oh!
There was an error while loading. Please reload this page.