improve function argument ordering in pvsystem #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good at a high level, but I noticed that you didn't do the same type of reordering for the sapm function. I see that you have just updated sapm to better align with Matlab, but the intention was only to align algorithmically, right, so we'd still want the parameters ordered with effective_irradiance and temperature first? |
|
@jforbess I updated the sapm functions. I'll let this sit for another day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves some function signatures as discussed in #197.
Also addresses the input/output type issues described #201 for ashraeiam, physicaliam, and snlinverter.
Adds test_tools.py.
I'll merge tomorrow unless there are comments.
Closes #197.