Add 2025 coefficients for Huld model by OmarBahamida · Pull Request #2486 · pvlib/pvlib-python

OmarBahamida · 2025-06-17T15:07:45Z

Enhance Huld model with EU JRC coefficients

Introduced a new function to infer updated coefficients for the Huld model based on EU JRC research.
Added a parameter to the existing Huld function to optionally use these updated coefficients.
Updated documentation to reflect the new functionality and included references to the EU JRC paper.
Added tests to verify the implementation and ensure compatibility with existing functionality.

- Introduced a new function to infer updated coefficients for the Huld model based on EU JRC research. - Added a parameter to the existing Huld function to optionally use these updated coefficients. - Updated documentation to reflect the new functionality and included references to the EU JRC paper. - Added tests to verify the implementation and ensure compatibility with existing functionality. (cherry picked from commit f0ba338)

- Updated the test for the Huld model to use non-reference values for irradiance and temperature. - Enhanced the test to verify that results differ for all supported cell types when using EU JRC coefficients. - Added checks to ensure all cell types are supported and that a KeyError is raised for invalid cell types. (cherry picked from commit 7c0feba)

cwhanse · 2025-06-17T16:12:34Z

I'm -1 on the new kwarg use_eu_jrc. The way I read the 2025 reference, the intent is to replace the older set of coefficients, to reflect "modern" modules. If we need to retain the older coefficients for continuity, we can add a table to the docstring.

Comments for my fellow maintainers?

echedey-ls · 2025-06-18T09:39:32Z

I'm between @cwhanse and @OmarBahamida ; I prefer a version keyword only parameter that can be either 2025 or 2011, and defaults to the latest one. I think it's valuable to ease the use of older parameters, given their lifetime is long and post analysis of systems is great for diagnosis.

echedey-ls

Well done. Overall a good approach. Please, also add a whatsnew entry in docs/sphinx/source/whatsnew once you apply the new changes.

echedey-ls · 2025-06-18T09:41:44Z

pvlib/pvarray.py

+    .. [2] EU JRC paper, "Updated coefficients for the Huld model",
+           https://doi.org/10.1002/pip.3926


Looks like you didn't change this to fit the IEEE citation format nor the :doi: directive (see the citation just above).

I recommend you to read https://pvlib-python.readthedocs.io/en/latest/contributing/style_guide.html

echedey-ls · 2025-06-18T09:45:01Z

tests/test_pvarray.py

        res = pvarray.huld(1000, 25, 100)
+
+
+def test_huld_eu_jrc():


Can you check for some specific values, up to 4-5 decimals? It would be better if you calculate them outside of your Python implementation.

AdamRJensen · 2025-06-18T11:16:15Z

I'm between @cwhanse and @OmarBahamida ; I prefer a version keyword only parameter that can be either 2025 or 2011, and defaults to the latest one. I think it's valuable to ease the use of older parameters, given their lifetime is long and post analysis of systems is great for diagnosis.

I fully support this implementation. It would be a shame to remove existing features. This way we can also have a deprecation cycle, i.e., a period where a warning is raised if the version parameter is not specified. Eventually, we can make the breaking change of switching the default version to the most recent version of the coefficients.

cwhanse · 2025-06-18T14:13:36Z

Any set of coefficients can be provided directly to the existing function, so kwargs like version aren't strictly necessary.

But if we lean towards providing built-in parameters, as a convenience, or as a means to repeat previous analyses (where parameters were not explicit, which is a different problem), then I think the user should be required to affirmatively select them: version=None would have my vote.

adriesse · 2025-06-25T14:18:32Z

I think I lean towards @AdamRJensen 's suggestion, which maintains the default behaviour for now.

cwhanse · 2025-07-18T14:07:48Z

@OmarBahamida any plan to move this forward? If not, I will do so. Thanks for starting this change.

remove trailing whitespace and break long lines

OmarBahamida · 2025-07-20T10:09:49Z

Hi all,
I’ve just pushed changes to fix the Flake8 linter errors (trailing whitespace and long lines).
I also verified that all new code is fully covered by tests (100% coverage for pvlib/pvarray.py).
Sorry for my late response, I haven’t had enough time recently, but I appreciate your patience.
Thank you for your feedback and support.

remove whitespace from blank lines and break long lines - Removed trailing whitespace from blank lines in pvlib/pvarray.py - Broke long lines in function definitions and assertions to comply with line length limits - Reformatted comments and code in tests/test_pvarray.py for Flake8 compliance

cwhanse · 2025-07-21T16:29:26Z

@OmarBahamida we'd like to get this change into the next release. I took the liberty of restructuring the new kwarg and the test that looks up the coefficients.

OmarBahamida · 2025-07-21T18:33:44Z

@cwhanse Thank you very much for your help and for restructuring the code and tests! I’m glad to hear this will be included in the next release. I appreciate your feedback and support throughout this process.

…2461

cwhanse · 2025-07-22T14:55:26Z

@pvlib/pvlib-maintainer this is ready for reviews

adriesse

Looks good to me.

pvlib/pvarray.py

Co-authored-by: Anton Driesse <[email protected]>

echedey-ls

Absolute nice tests! LGTM :)

pvlib/pvarray.py

echedey-ls · 2025-07-23T17:42:00Z

Well, I guess at some point pvlib will have to change the default constants year, but that can be a problem for the future pvlib.

Co-authored-by: Echedey Luis <[email protected]>

pvlib/pvarray.py

kandersolar · 2025-07-25T14:24:23Z

pvlib/pvarray.py

-                           -0.001256, 0.000001),
-                   'cdte': (-0.046689, -0.072844, -0.002262, 0.000276,
-                            0.000159, -0.000006)}
+    if k_version == '2011':


I don't think '2011' is a good choice of identifier for the older coefficients. To me it suggests the 2011 paper is the source of those coefficients, which isn't the case.

I think something like PVGIS5.3 (the current version) and PVGIS{something} could be a good option, but I don't know what version will have the new coefficients. I've emailed Nikos Alexandris at JRC asking about this.

Nikos responded that PVGIS 6 will use the new coefficients by default. Maybe PVGIS5 and PVGIS6 are good identifiers, then.

…2461

adriesse · 2025-08-07T08:02:21Z

pvlib/pvarray.py

+        Either ``'pvgis5'`` (default) or ``'pvgis6'``. Selects values
+        for ``k`` if ``k`` is not specified. If ``'pvgis5'``, values are
+        from PVGIS documentation and are labeled in [2]_ as "current".
+        If ``'pvgis6'`` values are from [2]_ labeled as "updated".


Suggested change

Either ``'pvgis5'`` (default) or ``'pvgis6'``. Selects values

for ``k`` if ``k`` is not specified. If ``'pvgis5'``, values are

from PVGIS documentation and are labeled in [2]_ as "current".

If ``'pvgis6'`` values are from [2]_ labeled as "updated".

Selects a set of values for ``k`` if ``k`` is not specified: either ``'pvgis5'`` (default)

or ``'pvgis6'``. For ``'pvgis5'``, ``k`` values are from PVGIS documentation,

which are also identified as "current" in [2]_ . For ``'pvgis6'``, values are

from [2]_ where they are labeled as "updated".

I'll not take this suggestion as the phrasing implies that a value of 'pvgis5' is assigned to k rather than being a value of k_version.

kandersolar

One typo to fix, otherwise LGTM

pvlib/pvarray.py

…into pr/2486

kandersolar · 2025-09-23T19:34:46Z

Thanks @OmarBahamida and all other contributors here!

OmarBahamida added 2 commits June 17, 2025 16:56

echedey-ls reviewed Jun 18, 2025

View reviewed changes

echedey-ls added this to the v0.13.1 milestone Jun 18, 2025

echedey-ls added enhancement api labels Jun 18, 2025

echedey-ls mentioned this pull request Jun 18, 2025

Update zenith and azimuth angle documentation #2485

Merged

6 tasks

Fix Flake8 linter errors

1833dc1

remove trailing whitespace and break long lines

OmarBahamida and others added 2 commits July 20, 2025 17:56

restructure lookup and test

241c272

cwhanse added 2 commits July 21, 2025 10:39

fix test and formatting

79f490f

adjust error message

a5a5ae8

cwhanse changed the title ~~Fix2461~~ Add 2025 coefficients for Huld model Jul 22, 2025

cwhanse added 2 commits July 22, 2025 08:51

Merge branch 'main' of https://github.com/pvlib/pvlib-python into fix…

aa7d3ee

…2461

add whatsnew

91da25c

adriesse reviewed Jul 23, 2025

View reviewed changes

pvlib/pvarray.py Outdated Show resolved Hide resolved

pvlib/pvarray.py Outdated Show resolved Hide resolved

Apply suggestions from code review

140b55b

Co-authored-by: Anton Driesse <[email protected]>

echedey-ls approved these changes Jul 23, 2025

View reviewed changes

pvlib/pvarray.py Outdated Show resolved Hide resolved

Update pvlib/pvarray.py

752ef05

Co-authored-by: Echedey Luis <[email protected]>

cwhanse reviewed Jul 23, 2025

View reviewed changes

pvlib/pvarray.py Outdated Show resolved Hide resolved

Update pvlib/pvarray.py

0703ac1

cwhanse reviewed Jul 23, 2025

View reviewed changes

pvlib/pvarray.py Outdated Show resolved Hide resolved

Update pvlib/pvarray.py

889805b

kandersolar reviewed Jul 24, 2025

View reviewed changes

pvlib/pvarray.py Outdated Show resolved Hide resolved

cwhanse added 3 commits July 24, 2025 16:04

correct coefficients for 2025 and references

57edf70

fix conflict

92b5cde

fix docstring

8b41911

kandersolar reviewed Jul 25, 2025

View reviewed changes

cwhanse added 5 commits August 6, 2025 09:00

change parameter key to pvgis5, etc.

89727f3

Merge branch 'main' of https://github.com/pvlib/pvlib-python into fix…

5052843

…2461

error message

607938d

lint

cafd131

fix test

d078e74

adriesse approved these changes Aug 7, 2025

View reviewed changes

kandersolar mentioned this pull request Sep 19, 2025

v0.13.1 release planning #2546

Closed

9 tasks

Merge branch 'main' into fix2461

a23f5cd

kandersolar approved these changes Sep 19, 2025

View reviewed changes

pvlib/pvarray.py Outdated Show resolved Hide resolved

pvlib/pvarray.py Outdated Show resolved Hide resolved

kandersolar added 4 commits September 23, 2025 15:05

Merge branch 'main' into fix2461

c74a279

Apply suggestions from code review

a1ea251

Merge remote-tracking branch 'upstream/main' into pr/2486

4d56803

Merge branch 'fix2461' of https://github.com/OmarBahamida/pvlib-python …

a72d557

…into pr/2486

kandersolar merged commit a994fb7 into pvlib:main Sep 23, 2025
26 of 27 checks passed

		.. [2] EU JRC paper, "Updated coefficients for the Huld model",
		https://doi.org/10.1002/pip.3926

Conversation

OmarBahamida commented Jun 17, 2025 • edited by kandersolar Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cwhanse commented Jun 17, 2025

Uh oh!

echedey-ls commented Jun 18, 2025

Uh oh!

echedey-ls left a comment

Choose a reason for hiding this comment

Uh oh!

echedey-ls Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

echedey-ls Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

AdamRJensen commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cwhanse commented Jun 18, 2025

Uh oh!

adriesse commented Jun 25, 2025

Uh oh!

cwhanse commented Jul 18, 2025

Uh oh!

OmarBahamida commented Jul 20, 2025

Uh oh!

cwhanse commented Jul 21, 2025

Uh oh!

OmarBahamida commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cwhanse commented Jul 22, 2025

Uh oh!

adriesse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

echedey-ls left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

echedey-ls commented Jul 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kandersolar Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

kandersolar Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

adriesse Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cwhanse Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

kandersolar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kandersolar commented Sep 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

OmarBahamida commented Jun 17, 2025 •

edited by kandersolar

Loading

AdamRJensen commented Jun 18, 2025 •

edited

Loading

OmarBahamida commented Jul 21, 2025 •

edited

Loading

adriesse Aug 7, 2025 •

edited

Loading