Adding functions for retrieving NSRDB PSM4 Polar datasets#2640
Open
etoni044 wants to merge 2 commits intopvlib:mainfrom
Open
Adding functions for retrieving NSRDB PSM4 Polar datasets#2640etoni044 wants to merge 2 commits intopvlib:mainfrom
etoni044 wants to merge 2 commits intopvlib:mainfrom
Conversation
Added two new functions to psm4.py: get_nsrdb_psm4_polar and get_nsrdb_psm4_polar_tmy using the methodology created for other psm4 datasets.
Updating __init__.py to include new polar functions
Member
|
Thanks @etoni044, the functions look good on first glance. The next step for this PR will be to add tests. #2378 is an example you can follow. And here is some general info about testing: https://pvlib-python.readthedocs.io/en/stable/contributing/testing.html If you get stuck, feel free to update this PR with whatever code you have and someone will come help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two new functions to psm4.py: get_nsrdb_psm4_polar and get_nsrdb_psm4_polar_tmy using the methodology created for other psm4 datasets.
I'm not entirely sure how to proceed with this pull request, as this is my first time going through the process.
Checklist:
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.