Skip to content

Support ideal PV devices (#324) #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Sep 29, 2017
Merged

Support ideal PV devices (#324) #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
9ab2e95
Add draft i_from_v_alt function with tests
Jun 15, 2017
a66abc4
Merge branch 'master' of github.com:pvlib/pvlib-python
Jun 15, 2017
a19447b
Better comments and more explicit typing
Jun 15, 2017
76616d5
Use transform from shunt resistance to shunt conductance
Jun 15, 2017
e35412f
Add v_from_i_alt() with initial tests and use np.where
Jun 16, 2017
82217fd
Use test fixtures
Jun 21, 2017
135ce4c
Add @requires_scipy to test fixtures
Jun 23, 2017
f927aef
More current_sum_at_diode_node() tests and using fixture
Jun 23, 2017
741a7f4
Naming, documentation, and formatting
Jun 23, 2017
c9129dc
Deprecate replaced functions and flake8
Jul 27, 2017
3aa150d
Merge branch 'master' of github.com:pvlib/pvlib-python
Jul 27, 2017
85e957d
Add release documentation and flake8 again
Jul 27, 2017
fb22171
Replace deprecated function usages and update test_singlediode_series…
Jul 27, 2017
275eccc
Merge branch 'master' of github.com:pvlib/pvlib-python
Sep 10, 2017
cdd2bd9
Conform to existing API
Sep 11, 2017
223275a
Run flake8
Sep 11, 2017
6b50ad9
Implement some code quality suggestions
Sep 11, 2017
e4e09be
Remove extraneous print statements
Sep 11, 2017
37484f1
Better docstrings
Sep 11, 2017
f9c4c82
Fix parameter ranges in docstrings
Sep 11, 2017
26eabde
Add test that overflows lambertw arg
Sep 11, 2017
4d7754d
Add test for mixed solution types logic
Sep 11, 2017
03ae51e
Use broadcast_arrays for cleaner code
Sep 12, 2017
6c410d2
One more simplification
Sep 12, 2017
19af023
Better use of broadcast_arrays
Sep 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/sphinx/source/api.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,10 @@ Functions relevant for the single diode model.
.. autosummary::
:toctree: generated/

pvsystem.singlediode
pvsystem.calcparams_desoto
pvsystem.v_from_i
pvsystem.i_from_v
pvsystem.singlediode
pvsystem.v_from_i
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetized.


SAPM model
----------
Expand Down
17 changes: 17 additions & 0 deletions docs/sphinx/source/whatsnew/v0.5.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,35 @@ Bug fixes
Enhancements
~~~~~~~~~~~~
* Improve clearsky.lookup_linke_turbidity speed. (:issue:`368`)
* Ideal devices supported in single diode model, e.g.,
resistance_series = 0 and/or resistance_shunt = numpy.inf (:issue:`340`)
* `pvsystem.v_from_i` and `pvsystem.i_from_v` computations for near ideal
devices are more numerically stable. However, very, very near ideal
resistance_series and/or resistance_shunt may still cause issues with the
implicit solver (:issue:`340`)

API Changes
~~~~~~~~~~~
* `pvsystem.v_from_i` and `pvsystem.i_from_v` functions now accept
resistance_series = 0 and/or resistance_shunt = numpy.inf as inputs
(:issue:`340`)

Documentation
~~~~~~~~~~~~~
* Doc string of modelchain.basic_chain was updated to describe args
more accurately
* Doc strings of `singlediode`, `pvsystem.v_from_i`, and `pvsystem.i_from_v`
were updated to describe acceptable input arg ranges

Testing
~~~~~~~
* Changed test for clearsky.haurwitz to operate on zenith angles
* Significant new test cases added for `pvsystem.v_from_i` and
`pvsystem.i_from_v` (:issue:`340`)

Contributors
~~~~~~~~~~~~
* Cliff Hansen
* KonstantinTr
* Will Holmgren
* Mark Campanelli
2 changes: 1 addition & 1 deletion pvlib/atmosphere.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ def first_solar_spectral_correction(pw, airmass_absolute, module_type=None,
The module used to calculate the spectral correction
coefficients corresponds to the Mult-crystalline silicon
Manufacturer 2 Model C from [3]_. Spectral Response (SR) of CIGS
and a-Si modules used to derive coefficients can be found in [4]_
and a-Si modules used to derive coefficients can be found in [4]_

coefficients : None or array-like, default None
allows for entry of user defined spectral correction
Expand Down
Loading