Skip to content

make ModelChain use solar_position_method argument #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2017
Merged

make ModelChain use solar_position_method argument #379

merged 2 commits into from
Oct 9, 2017

Conversation

wholmgren
Copy link
Member

  • Closes issue ModelChain does not use solar_position_method kwarg #377
  • Fully tested. -- Probably could be tested using mock, but I don't have the time to figure it out right now.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff and/or landscape.io linting service.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.

I'll merge in a few days unless someone wants to provide some advice on testing.

@wholmgren wholmgren added the bug label Oct 1, 2017
@wholmgren wholmgren added this to the 0.5.1 milestone Oct 1, 2017
@wholmgren wholmgren merged commit 8e1fe41 into pvlib:master Oct 9, 2017
@wholmgren wholmgren mentioned this pull request Dec 14, 2017
Closed
@wholmgren wholmgren deleted the mcsolpos branch August 28, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.
1 participant
@wholmgren