Skip to content

unset irradiance.py and test_irradiance.py executable bits #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 16, 2018
Merged

unset irradiance.py and test_irradiance.py executable bits #461

merged 4 commits into from
May 16, 2018

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented May 14, 2018 •
edited
Loading

  • Closes change permissions on irradiance.py #460
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests must pass on the TravisCI and Appveyor testing services.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff and/or landscape.io linting service.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.

Also adds whatsnew file for 0.6.0

@wholmgren wholmgren added the bug label May 14, 2018
@wholmgren wholmgren added this to the 0.6.0 milestone May 14, 2018
@wholmgren wholmgren changed the title unset irradiance.py executable bit unset irradiance.py and test_irradiance.py executable bits May 14, 2018
@wholmgren wholmgren merged commit 8da6afc into pvlib:master May 16, 2018
@wholmgren wholmgren deleted the irradiancex branch May 19, 2018 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@wholmgren