Skip to content

change irradiance.perez(return_components=True) to return dict/DataFrame #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2018

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Sep 6, 2018

  • Closes Return sky diffuse and components as dataframe in irradiance.perez #434
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

If we're limiting #434 and this PR to irradiance.perez then this is close to mergeable.

@wholmgren wholmgren added the api label Sep 6, 2018
@wholmgren wholmgren added this to the 0.6.0 milestone Sep 6, 2018
@wholmgren wholmgren requested a review from cwhanse September 6, 2018 18:33
@wholmgren wholmgren merged commit 2b51d4a into pvlib:master Sep 7, 2018
@wholmgren wholmgren deleted the skydiff branch September 7, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return sky diffuse and components as dataframe in irradiance.perez
2 participants