Skip to content

Update module and inverter files (#761) #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/sphinx/source/whatsnew/v0.7.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ Enhancements
~~~~~~~~~~~~
* Created two new incidence angle modifier functions: :py:func:`pvlib.pvsystem.iam_martin_ruiz`
and :py:func:`pvlib.pvsystem.iam_interp`. (:issue:`751`)
* Updated the file for module parameters for the CEC model, from the SAM file
dated 2017-6-5 to the SAM file dated 2019-03-05. (:issue:`761`)
* Updated the file for inverter parameters for the CEC model, from the SAM file
dated 2018-3-18 to the SAM file dated 2019-03-05. (:issue:`761`)
* Added recombination current parameters to bishop88 single-diode functions and also
to :py:func:`pvlib.pvsystem.max_power_point`. (:issue:`762`)

Expand Down
5,103 changes: 0 additions & 5,103 deletions pvlib/data/sam-library-cec-inverters-2018-3-18.csv

This file was deleted.

3,267 changes: 3,267 additions & 0 deletions pvlib/data/sam-library-cec-inverters-2019-03-05.csv

Large diffs are not rendered by default.

19,257 changes: 0 additions & 19,257 deletions pvlib/data/sam-library-cec-modules-2017-6-5.csv

This file was deleted.

21,538 changes: 21,538 additions & 0 deletions pvlib/data/sam-library-cec-modules-2019-03-05.csv

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions pvlib/pvsystem.py
Original file line number Diff line number Diff line change
Expand Up @@ -1763,7 +1763,7 @@ def retrieve_sam(name=None, path=None):
os.path.dirname(os.path.abspath(__file__)), 'data')
if name == 'cecmod':
csvdata = os.path.join(
data_path, 'sam-library-cec-modules-2017-6-5.csv')
data_path, 'sam-library-cec-modules-2019-03-05.csv')
elif name == 'sandiamod':
csvdata = os.path.join(
data_path, 'sam-library-sandia-modules-2015-6-30.csv')
Expand All @@ -1773,7 +1773,7 @@ def retrieve_sam(name=None, path=None):
# Allowing either, to provide for old code,
# while aligning with current expectations
csvdata = os.path.join(
data_path, 'sam-library-cec-inverters-2018-3-18.csv')
data_path, 'sam-library-cec-inverters-2019-03-05.csv')
else:
raise ValueError('invalid name {}'.format(name))
elif path is not None:
Expand Down
10 changes: 8 additions & 2 deletions pvlib/test/test_pvsystem.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,14 @@ def test_retrieve_sam_cecmod():
'Adjust',
'gamma_r',
'Version',
'STC',
'PTC',
'Technology',
'Bifacial',
'Length',
'Width',
]
module = 'iTek_iT_300_HE'
module = 'Itek_Energy_LLC_iT_300_HE'
assert module in data
assert set(data[module].keys()) == set(keys)

Expand All @@ -304,8 +308,10 @@ def test_retrieve_sam_cecinverter():
'Idcmax',
'Mppt_low',
'Mppt_high',
'CEC_Date',
'CEC_Type',
]
inverter = 'Solectria__PVI_5300_5300_P_208V__CEC_2008_'
inverter = 'Yaskawa_Solectria_Solar__PVI_5300_208__208V_'
assert inverter in data
assert set(data[inverter].keys()) == set(keys)

Expand Down