Skip to content

pass temperature, pressure to modelchain sol pos call #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

Ahanmr
Copy link
Contributor

@Ahanmr Ahanmr commented Mar 18, 2020

This PR handles, the case where pressure or temp_air is not in weather, using the pvlib.tools._build_kwargs method, as keyword arguments. #893

This PR handles, the case where pressure or temp_air is not in weather, using the pvlib.tools._build_kwargs method, as keyword arguments. pvlib#893
@Ahanmr Ahanmr changed the title Updated modelchain.py #893 Updated modelchain.py #523 Mar 18, 2020
@Ahanmr
Copy link
Contributor Author

Ahanmr commented Mar 18, 2020

@cwhanse How do I resolve the codecov error here?

@Ahanmr
Copy link
Contributor Author

Ahanmr commented Mar 18, 2020

Since, the code successfully passes all checks except these two codecov tests.

@cwhanse
Copy link
Member

cwhanse commented Mar 19, 2020

@cwhanse How do I resolve the codecov error here?

Don't worry about it. codecov isn't hitting the 95% target due to raise statements, and a few untested lines that are outside this PR.

@cwhanse cwhanse added this to the 0.7.2 milestone Mar 19, 2020
@cwhanse
Copy link
Member

cwhanse commented Apr 8, 2020

@Ahanmr just pinging you about this PR - can you add a line to the whatsnew v0.7.2 file, and add yourself to the Contributors section? Or if circumstances prevent you, I can do it for you.

@wholmgren wholmgren changed the title Updated modelchain.py #523 pass temperature, pressure to modelchain sol pos call Apr 8, 2020
@Ahanmr
Copy link
Contributor Author

Ahanmr commented Apr 14, 2020

Yes @cwhanse ! I'll do this right away! Thank you!

@cwhanse cwhanse mentioned this pull request Apr 14, 2020
3 tasks
Copy link
Contributor

@CameronTStark CameronTStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Ahanmr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants