[DOC] pvsystem.singlediode math rendering #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandersolar
changed the title
cwhanse
reviewed
May 22, 2020
|
Also @kanderso-nrel it would be worth adding a "See also" section to the docstring if you are so inclined, pointing to the calcparams_desoto, calcparams_pvsyst and calcparams_cec functions. |
Co-authored-by: Cliff Hansen <[email protected]>
|
@cwhanse There was a "See also" section already, way at the bottom. I added the missing functions to it. Maybe move it to above the references? |
According to the numpy guide the order should be |
cwhanse
approved these changes
Jun 2, 2020
|
Thanks @kanderso-nrel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #xxxxTests addedUpdates entries todocs/sphinx/source/api.rstfor API changes.Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.Per @mikofski's suggestion here: #967 (review)
The
Returnssection still doesn't look great, but I'd rather not deal with that here if that's okay.Built version: https://pvlib-python--971.org.readthedocs.build/en/971/generated/pvlib.pvsystem.singlediode.html