-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adds ability for soiling.Hsu to accept arbitrary time intervals (other than 1 hour) #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick comments. Would also be good to add a test that uses non-hourly data.
Other than the small whatsnew changes, the only thing I see is that the test has |
FYI test failure is the shapely segfault |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of suggestions/questions but ok to merge
Thanks @jsstein and @kanderso-nrel! |
docs/sphinx/source/api.rst
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).