Skip to content

Adds ability for soiling.Hsu to accept arbitrary time intervals (other than 1 hour) #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Aug 28, 2020

Conversation

jsstein
Copy link
Contributor

@jsstein jsstein commented Jun 12, 2020

  • Closes pvlib.soiling.hsu model implementation errors #970
  • I am familiar with the contributing guidelines
  • [no changes needed] Tests added
  • [N/A] Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick comments. Would also be good to add a test that uses non-hourly data.

@cwhanse cwhanse added this to the 0.8.0 milestone Jun 18, 2020
@wholmgren
Copy link
Member

@cwhanse @kanderso-nrel @jsstein what's needed to move this PR forward? Looks pretty close to me.

@kandersolar
Copy link
Member

Other than the small whatsnew changes, the only thing I see is that the test has @needs_pandas_0_22, which is no longer necessary as of #1003

@kandersolar
Copy link
Member

FYI test failure is the shapely segfault

Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of suggestions/questions but ok to merge

@wholmgren
Copy link
Member

Thanks @jsstein and @kanderso-nrel!

@wholmgren wholmgren merged commit 37fba6b into pvlib:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pvlib.soiling.hsu model implementation errors
4 participants