Skip to content

fix(build): pin react-bootstrap; upgrade to react v15 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

gabrielrtakeda
Copy link

@gabrielrtakeda gabrielrtakeda commented Nov 6, 2020

related: #2

before

image

Full log

yarn dev
yarn run v1.22.10
$ webpack-dev-server --content-base build/
Project is running at http://localhost:8080/
webpack output is served from /
Content not from webpack is served from /Users/gabrielrtakeda/code/_labs/react-regexr/build
Hash: 24a7b9734117e8fd58e2
Version: webpack 2.7.0
Time: 5573ms
     Asset     Size  Chunks                    Chunk Names
    web.js  1.64 MB       0  [emitted]  [big]  web.js
styles.css  13.9 kB    1, 1  [emitted]         styles.css, styles.css
chunk    {0} web.js (web.js) 1.61 MB [entry] [rendered]
    [0] ./~/process/browser.js 5.43 kB {0} [built]
   [12] ./~/react/index.js 189 bytes {0} [built]
   [14] ./~/react-addons-pure-render-mixin/index.js 429 bytes {0} [built]
   [22] (webpack)-dev-server/client?http://localhost:8080 7.93 kB {0} {1} [built]
   [36] ./~/loglevel/lib/loglevel.js 8.88 kB {0} {1} [built]
   [42] ./~/react-dom/index.js 58 bytes {0} [built]
   [60] ./~/strip-ansi/index.js 161 bytes {0} {1} [built]
   [61] ./~/url/url.js 22.8 kB {0} {1} [built]
   [63] (webpack)-dev-server/client/overlay.js 3.67 kB {0} {1} [built]
   [64] (webpack)-dev-server/client/socket.js 1.08 kB {0} {1} [built]
   [66] (webpack)/hot/emitter.js 74 bytes {0} {1} [built]
   [67] (webpack)/hot nonrecursive ^\.\/log$ 160 bytes {0} {1} [built]
  [104] ./dev/Init.js 273 bytes {0} [built]
  [106] ./dev/MainPage.js 2.84 kB {0} [built]
  [215] multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js 40 bytes {0} [built]
     + 199 hidden modules
chunk    {1} styles.css, styles.css (styles.css) 360 kB [entry] [rendered]
   [22] (webpack)-dev-server/client?http://localhost:8080 7.93 kB {0} {1} [built]
   [31] ./~/ansi-regex/index.js 139 bytes {0} {1} [built]
   [34] ./~/html-entities/lib/index.js 449 bytes {0} {1} [built]
   [36] ./~/loglevel/lib/loglevel.js 8.88 kB {0} {1} [built]
   [37] ./~/node-libs-browser/~/events/events.js 13.5 kB {0} {1} [built]
   [38] ./~/punycode/punycode.js 14.7 kB {0} {1} [built]
   [60] ./~/strip-ansi/index.js 161 bytes {0} {1} [built]
   [61] ./~/url/url.js 22.8 kB {0} {1} [built]
   [62] ./~/url/util.js 315 bytes {0} {1} [built]
   [63] (webpack)-dev-server/client/overlay.js 3.67 kB {0} {1} [built]
   [64] (webpack)-dev-server/client/socket.js 1.08 kB {0} {1} [built]
   [66] (webpack)/hot/emitter.js 74 bytes {0} {1} [built]
   [67] (webpack)/hot nonrecursive ^\.\/log$ 160 bytes {0} {1} [built]
  [105] ./assets/main.scss 41 bytes {1} [built]
  [214] multi (webpack)-dev-server/client?http://localhost:8080 ./assets/main.scss 40 bytes {1} [built]
     + 10 hidden modules

ERROR in ./src/FlagsEditor.js
Module not found: Error: Can't resolve 'react-bootstrap/lib/Overlay' in '/Users/gabrielrtakeda/code/_labs/react-regexr/src'
 @ ./src/FlagsEditor.js 6:14-52
 @ ./src/ExpressionEditor.js
 @ ./dev/MainPage.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/findDOMNode.js
Module not found: Error: Can't resolve 'react/lib/ReactCurrentOwner' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/findDOMNode.js 13:24-62
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactMount.js
Module not found: Error: Can't resolve 'react/lib/ReactCurrentOwner' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactMount.js 17:24-62
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactDOMNullInputValuePropHook.js
Module not found: Error: Can't resolve 'react/lib/ReactComponentTreeHook' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactDOMNullInputValuePropHook.js 11:29-72
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactDOMUnknownPropertyHook.js
Module not found: Error: Can't resolve 'react/lib/ReactComponentTreeHook' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactDOMUnknownPropertyHook.js 13:29-72
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactDOMInvalidARIAHook.js
Module not found: Error: Can't resolve 'react/lib/ReactComponentTreeHook' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactDOMInvalidARIAHook.js 12:29-72
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactMount.js
Module not found: Error: Can't resolve 'react/lib/React' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactMount.js 15:12-38
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactNodeTypes.js
Module not found: Error: Can't resolve 'react/lib/React' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactNodeTypes.js 14:12-38
 @ ./~/react-dom/lib/getHostComponentFromComposite.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactDebugTool.js
Module not found: Error: Can't resolve 'react/lib/ReactComponentTreeHook' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactDebugTool.js 14:29-72
 @ ./~/react-dom/lib/ReactInstrumentation.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactUpdateQueue.js
Module not found: Error: Can't resolve 'react/lib/ReactCurrentOwner' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactUpdateQueue.js 13:24-62
 @ ./~/react-dom/lib/ReactMount.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/instantiateReactComponent.js
Module not found: Error: Can't resolve 'react/lib/getNextDebugID' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/instantiateReactComponent.js 18:21-56
 @ ./~/react-dom/lib/ReactMount.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactDOMOption.js
Module not found: Error: Can't resolve 'react/lib/React' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactDOMOption.js 13:12-38
 @ ./~/react-dom/lib/ReactDOMComponent.js
 @ ./~/react-dom/lib/ReactDefaultInjection.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactMultiChild.js
Module not found: Error: Can't resolve 'react/lib/ReactCurrentOwner' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactMultiChild.js 17:24-62
 @ ./~/react-dom/lib/ReactDOMComponent.js
 @ ./~/react-dom/lib/ReactDefaultInjection.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactCompositeComponent.js
Module not found: Error: Can't resolve 'react/lib/React' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactCompositeComponent.js 14:12-38
 @ ./~/react-dom/lib/instantiateReactComponent.js
 @ ./~/react-dom/lib/ReactMount.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactCompositeComponent.js
Module not found: Error: Can't resolve 'react/lib/ReactCurrentOwner' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactCompositeComponent.js 16:24-62
 @ ./~/react-dom/lib/instantiateReactComponent.js
 @ ./~/react-dom/lib/ReactMount.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/LinkedValueUtils.js
Module not found: Error: Can't resolve 'react/lib/React' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/LinkedValueUtils.js 16:12-38
 @ ./~/react-dom/lib/ReactDOMTextarea.js
 @ ./~/react-dom/lib/ReactDOMComponent.js
 @ ./~/react-dom/lib/ReactDefaultInjection.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/flattenChildren.js
Module not found: Error: Can't resolve 'react/lib/ReactComponentTreeHook' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/flattenChildren.js 24:27-70 40:33-76
 @ ./~/react-dom/lib/ReactMultiChild.js
 @ ./~/react-dom/lib/ReactDOMComponent.js
 @ ./~/react-dom/lib/ReactDefaultInjection.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/ReactChildReconciler.js
Module not found: Error: Can't resolve 'react/lib/ReactComponentTreeHook' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactChildReconciler.js 27:27-70 35:31-74
 @ ./~/react-dom/lib/ReactMultiChild.js
 @ ./~/react-dom/lib/ReactDOMComponent.js
 @ ./~/react-dom/lib/ReactDefaultInjection.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/checkReactTypeSpec.js
Module not found: Error: Can't resolve 'react/lib/ReactComponentTreeHook' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/checkReactTypeSpec.js 27:27-70 69:37-80
 @ ./~/react-dom/lib/ReactCompositeComponent.js
 @ ./~/react-dom/lib/instantiateReactComponent.js
 @ ./~/react-dom/lib/ReactMount.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js

ERROR in ./~/react-dom/lib/traverseAllChildren.js
Module not found: Error: Can't resolve 'react/lib/ReactCurrentOwner' in '/Users/gabrielrtakeda/code/_labs/react-regexr/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/traverseAllChildren.js 13:24-62
 @ ./~/react-dom/lib/flattenChildren.js
 @ ./~/react-dom/lib/ReactMultiChild.js
 @ ./~/react-dom/lib/ReactDOMComponent.js
 @ ./~/react-dom/lib/ReactDefaultInjection.js
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
 @ ./dev/Init.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./dev/Init.js
Child extract-text-webpack-plugin:
    chunk    {0} extract-text-webpack-plugin-output-filename 72.3 kB [entry] [rendered]
        [0] ./~/css-loader/lib/css-base.js 2.19 kB {0} [built]
        [1] ./~/base64-js/index.js 3.79 kB {0} [built]
        [2] ./~/ieee754/index.js 2.17 kB {0} [built]
        [3] ./~/isarray/index.js 131 bytes {0} [built]
        [4] ./~/node-libs-browser/~/buffer/index.js 48.7 kB {0} [built]
        [5] (webpack)/buildin/global.js 487 bytes {0} [built]
        [6] ./~/css-loader!./~/sass-loader/lib/loader.js?{"includePaths":["/Users/gabrielrtakeda/code/_labs/react-regexr/~/regexr/scss/third-party/compass-mixins"]}!./assets/main.scss 14.8 kB {0} [built]
webpack: Failed to compile.
^[

after

image

@gabrielrtakeda gabrielrtakeda changed the title fix(build): pin react-bootstrap; replace react pure mixin fix(build): pin react-bootstrap; upgrade to react v15 Nov 6, 2020
@pxpeterxu
Copy link
Owner

This looks great! Honestly, the only thing I'd change is the React Bootstrap versioning to ^0.33.1, but otherwise, I think this is good to go

@pxpeterxu pxpeterxu reopened this Nov 9, 2020
@gabrielrtakeda
Copy link
Author

gabrielrtakeda commented Nov 9, 2020

hi @pxpeterxu thanks for the reply! I've closed the PR before because I used the branch master to replace the react for preact... I found the job you did in this project very nice, exposing the regexr's javascript api to be reusable. Is there any chances to update the project to use the latest version of regexr in similar way that you've did in pxpeterxu/regexr?

I'll update the PR to merge only the part before I replaced the react by preact. I was thinking to create another repo based on this for the preact version.. Do you agree?

@5E7EN
Copy link

5E7EN commented Nov 26, 2020

Thanks for this fix, @gabrielrtakeda! Looking forward to the merge...

@psiservices-ketan-javia

@gabrielrtakeda is there any plan to merge this PR to the main repo and release a new version? It's currently unusable when referenced from NPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants