Skip to content

Properly close http clients #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Properly close http clients #538

merged 1 commit into from
May 5, 2025

Conversation

ewjoachim
Copy link
Member

@ewjoachim ewjoachim commented May 4, 2025 •
edited
Loading

Closes #537

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2025

End-to-end public repo

Admin commands cheatsheet:

  • /e2e (in approved PR review body): Trigger end-to-end tests on external contributions
  • /invite (in comment): Invite the author & admins to the end-to-end private repo

@ewjoachim ewjoachim enabled auto-merge May 4, 2025 15:59
@ewjoachim ewjoachim disabled auto-merge May 4, 2025 17:44
@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  coverage_comment
  main.py
Project Total  

This report was generated by python-coverage-comment-action

@ewjoachim ewjoachim changed the title Try switching to unreleased pytest 8.4 in the hopes of understanding a test failure on main Properly close http clients May 5, 2025
@ewjoachim ewjoachim enabled auto-merge May 5, 2025 07:00
@ewjoachim ewjoachim merged commit e264e86 into main May 5, 2025
2 checks passed
@ewjoachim ewjoachim deleted the fix-ci branch May 5, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure on main only
1 participant
@ewjoachim