Skip to content

Conversation

dsliwka
Copy link
Contributor

@dsliwka dsliwka commented Aug 18, 2025

Replaces the previously hard‑wired bottom panel model statistics logic in etable with more flexible system.

Key changes:

  • New arguments: model_stats (list of attribute names without leading _) and model_stats_labels (optional label overrides).
  • Any model attribute can be displayed by listing its name without "_" (e.g. _r2_within -> "r2_within", _N -> "N"). Should therefore also work with future estimation methods and attributes.
  • Default (when model_stats=None) reproduces legacy behavior: ["N", "se_type?" if show_se_type, "r2", ("r2_within" if available else "adj_r2")].
  • Passing an empty list model_stats=[] suppresses all built‑in stats.

Addresses #983.

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 90.14085% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pyfixest/report/summarize.py 90.14% 7 Missing ⚠️
Flag Coverage Δ
core-tests 76.78% <90.14%> (?)
tests-extended ?
tests-vs-r 15.79% <2.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyfixest/report/summarize.py 88.86% <90.14%> (+78.97%) ⬆️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dsliwka
Copy link
Contributor Author

dsliwka commented Aug 18, 2025

pre-commit.ci autofix

@s3alfisc
Copy link
Member

Thank you Dirk, I'll try to take a look tomorrow (latest by Wednesday). Sorry for not replying earlier to your comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants