Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enh: Add tests pages - run tests in ci and locally to guide #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh: Add tests pages - run tests in ci and locally to guide #145
Changes from all commits
16734fb
67351a1
bc6a007
1b9d232
5d843a4
a55ab25
cdd2c09
0e6f7d4
10db00d
c4b5422
6aa3fd7
71a382e
d41b4fe
8b28c84
53b1818
838fbd0
ace9515
53dc089
3d55eab
0455fa7
0960184
2127510
7b7e3cc
c877af0
657784e
594cbeb
a419c08
5cac943
856dea6
2c26e4b
8fa276f
374f44a
9468b05
19a75ae
a28113b
9bf2be3
2304afd
7adf1c4
fa5a6ac
6146e7e
460c3a2
274723c
0e96047
794fa9d
bf513c4
ce9437f
116d01e
14deffc
fb63a37
c36e7f7
8764ba6
84df946
9f75135
0cef5df
4a99523
2442e98
4152451
0d28e06
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about something to notify the reader that
nox
doesn't need to be installed for the target python versions in order to manage them (as opposed to thevenv
, which must be present for each python version under test)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. i'm not sure if a beginner would get confused with that additional information or whether it would be useful. i hadn't thought about that before because nox just always worked! if you have suggestions for how to word it in a way that it doesn't make the user more confused i'm open to that!