Fix: social cards broken #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This atleast fixes the card image and makes it our logo. but we likely need to add metadata to generate cards specific to each page which might be a bigger project. merging this as the point of failure are a few bad links on the last lesson i merged (today). those links are to in progress lessons that i must have missed putting into TODO admonitions |
|
@lwasser I like that this PR is small in scope and is fluid. |
|
thank you @willingc i'm working on adjusting my workflow here! it will take some time as i still instinctually try to fix things when working on pr's ... i'm working on change!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.