Skip to content

Fix: update project name and make year automated #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Jan 11, 2024

This is a tiny pr that

  • Creates a more reader friendly project name (ends up in the meta tags and social previews)
  • Creates the copyright via an f-string so the year is always up to date.
  • Grabs the release value from git tags.

question - will that approach work in ci to get the tags that way? will we need to increase the fetch depth to ensure we already get a tag? Because we don't release often.

Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how it goes.

@lwasser
Copy link
Member Author

lwasser commented Jan 11, 2024

Great - i just fixed the two broken links hat were breaking the build (and will break every other build as well). will merge once this is all green.

@lwasser lwasser merged commit 518d937 into pyOpenSci:main Jan 11, 2024
@lwasser lwasser deleted the table-styles branch January 11, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants