Skip to content

Fix: multiple broken links #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Fix: multiple broken links #187

merged 3 commits into from
Mar 1, 2024

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Feb 27, 2024

No description provided.

@@ -223,7 +222,7 @@ above is a set of recommendations as you are just getting started. You may find
the need for other elements to be added to this file as you further develop your
package and as a community begins to use your package.

In the [next lesson](add-license-coc), you will add a LICENSE file to
In the [next lesson](add-license-coc.md), you will add a LICENSE file to
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link will be published friday of this week.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing htmlproofer in CI now but should pass once the link is up.

Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@lwasser
Copy link
Member Author

lwasser commented Mar 1, 2024

ok merging! thanks for the review @willingc !!

@lwasser lwasser merged commit 8a91b4c into pyOpenSci:main Mar 1, 2024
@lwasser lwasser deleted the fix-links branch March 1, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants