Skip to content

Review 2 (reviews open): Add: documentation section to package guide #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jan 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
8370452
ADD: documentation section to guide
lwasser Nov 30, 2022
f0e1a3c
Fix: Review edits from @lwasser and @arianesasso
lwasser Dec 13, 2022
d409543
Fix: add docstring examples
lwasser Dec 13, 2022
0431311
Fix: review edits to documentation section w @batalex
lwasser Dec 27, 2022
ec2d032
Fix: review edits to documentation from @arianesasso
lwasser Dec 27, 2022
8ced667
Fix: Review edits to doc section from @nickledave
lwasser Dec 27, 2022
8cc1bc3
Fix: edits to doc section from @simonmolinsky
lwasser Dec 27, 2022
dfea3b3
rebase
lwasser Dec 27, 2022
38fad88
Fix: numerous cleanup edits to contributing and readme files
lwasser Dec 28, 2022
70410f5
Fix: breakout docs into separate pages with separate goals and update…
lwasser Dec 28, 2022
8107341
Fix: add tutorial and coc text and general cleanup
lwasser Dec 29, 2022
0c28fd5
Update documentation/package-documentation-best-practices.md
lwasser Jan 9, 2023
a2b31e3
Update documentation/package-documentation-best-practices.md
lwasser Jan 9, 2023
179246d
Fix: addressing changes from @tupui
lwasser Jan 9, 2023
a696b89
Fix: add text to example in docstring and spaces review- @tupui
lwasser Jan 9, 2023
144eefd
Fix: update docstring with example text @tupui
lwasser Jan 9, 2023
116231c
Update documentation/index.md
lwasser Jan 9, 2023
1004cb4
Update documentation/website-hosting-optimizing-your-docs.md
lwasser Jan 9, 2023
044689f
Update documentation/website-hosting-optimizing-your-docs.md
lwasser Jan 9, 2023
22a5f4a
Fix: feedback from @tupui, @nickledave
lwasser Jan 9, 2023
444eae3
Update documentation/website-hosting-optimizing-your-docs.md
lwasser Jan 9, 2023
7e2e059
Fix: Major reorganization following comments from @sneakers-the-rat
lwasser Jan 10, 2023
fec16a5
Fix: massive update to the structure of the docs section
lwasser Jan 10, 2023
b78fc4f
Fix: responded to the 100+ comments left on this pr - phew
lwasser Jan 10, 2023
d73db2f
Fix: more fixes from @sneakers-the-rat review and @nickledave review
lwasser Jan 10, 2023
cccb65d
Fix: final cleanup of sections and removal of peer review checks
lwasser Jan 11, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-book.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
with:
directory: '_build/html'
arguments: |
--ignore-files "/.+\/_static\/.+/,/genindex.html/ "
--ignore-status-codes "403, 503"
--ignore-files "/.+\/_static\/.+/,/genindex.html/"
--ignore-status-codes "404, 403, 503"


26 changes: 25 additions & 1 deletion _static/pyos.css
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,19 @@ html, body {
font-size: 1.02rem;
}

body p {
}

.admonition {
margin-top: 40px;
margin-bottom: 40px;
}

h1, h2, h3, h4 {
}

h1 {
margin-top: 40px;
margin-top: 50px;
margin-bottom: 40px;
}
h2 {
Expand All @@ -18,3 +24,21 @@ h2 {
h3 {
margin-top: 40px}

figcaption .caption-text {
text-align: left!important;
}

figure {
margin-top: 60px!important;
margin-bottom: 60px!important;
}

figcaption {
font-size: .9em;
font-weight: bold;
}

.admonition p {
font-size: 1.1em;
font-weight: bold;
}
7 changes: 7 additions & 0 deletions ci-and-testing/intro.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# CI and Testing - Coming Soon!


This section is evolving and should be published by the end of Spring 2023


coming soon
20 changes: 13 additions & 7 deletions conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,25 @@
]

# colon fence for card support in md
myst_enable_extensions = ["colon_fence"]

myst_enable_extensions = [
"colon_fence",
"deflist",
]
#myst_heading_anchors = 3

# Link to our repo for easy PR/ editing
html_theme_options = {
"repository_url": "https://github.com/pyopensci/python-package-guide",
"use_repository_button": True,
"source_repository": "https://github.com/pyopensci/python-package-guide",
"source_branch": "main",
"source_directory": ".",
# "repository_url": "https://github.com/pyopensci/python-package-guide",
# "use_repository_button": True,
#"google_analytics_id": "UA-141260825-1",
#"show_toc_level": 1,
#"toc_title": "On this page",
"external_links": [
{"pyOpenSci Website": "link-one-name", "url": "https://www.pyopensci.org"}
],
# "external_links": [
# {"pyOpenSci Website": "link-one-name", "url": "https://www.pyopensci.org"}
# ],
"announcement": "🚧 UNDER CONSTRUCTION: this guide is under heavy construction right now. 🚧"
}

Expand Down
45 changes: 0 additions & 45 deletions documentation/contributing.md

This file was deleted.

211 changes: 0 additions & 211 deletions documentation/create-readme-files.md

This file was deleted.

26 changes: 26 additions & 0 deletions documentation/hosting-tools/intro.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Tools to Build and Host your Documentation

The most common tool for building documentation in the Python
ecosystem currently is Sphinx. However, some maintainers
are using tools like [mkdocs](https://www.mkdocs.org/) for documentation. It is
up to you to use the platform that you prefer for your documentation!

In this section, we introduce Sphinx as a common tool to
build documentation. We talk about various syntax options that you can use
when writing Sphinx documentation including mySt and rST.

We also talk about ways to publish your
documentation online and Sphinx tools that might help you optimize
your documentation website.

## Documentation build tools outline

```{toctree}
:maxdepth: 2

Intro <self>
Sphinx for Docs <sphinx-python-package-documentation-tools.md>
myST vs Markdown vs rst <myst-markdown-rst-doc-syntax.md>
Publish Your Docs <publish-documentation-online.md>
Website Hosting and Optimization <website-hosting-optimizing-your-docs.md>
```
Loading