Skip to content

docs: translate to Japanese TRANSLATING.md #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 4, 2024
Merged

docs: translate to Japanese TRANSLATING.md #363

merged 15 commits into from
Nov 4, 2024

Conversation

tkoyama010
Copy link
Member

ref #352

@tkoyama010
Copy link
Member Author

pre-commit.ci autofix

tkoyama010
tkoyama010 commented Aug 9, 2024
View reviewed changes
@tkoyama010 tkoyama010 marked this pull request as ready for review August 9, 2024 05:16
tkoyama010
tkoyama010 commented Aug 9, 2024
View reviewed changes
@tkoyama010 tkoyama010 changed the title docs: translate to Japanese TRANSLATING.po docs: translate to Japanese TRANSLATING.md Aug 9, 2024
@flpm flpm added translations Translation and localization of content lang-JA labels Aug 11, 2024
kozo2
kozo2 reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@kozo2 kozo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed the review.
I've added 8 comments.

@tkoyama010
Copy link
Member Author

@all-contributors please add @kozo2 for review

@allcontributors allcontributors bot mentioned this pull request Aug 12, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@tkoyama010

I've put up a pull request to add @kozo2! 🎉

@tkoyama010 tkoyama010 requested a review from kozo2 August 12, 2024 16:13
@tkoyama010
Copy link
Member Author

Thanks @kozo2 !

willingc
willingc approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR for structure. When @kozo2 is happy with translation, let's merge 😄

@tkoyama010 tkoyama010 merged commit bf60aea into pyOpenSci:main Nov 4, 2024
4 checks passed
@tkoyama010 tkoyama010 deleted the patch-3 branch November 4, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@kozo2 kozo2 Awaiting requested review from kozo2

Assignees
No one assigned
Labels
lang-JA translations Translation and localization of content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkoyama010 @kozo2 @willingc @flpm